This is an archive of the discontinued LLVM Phabricator instance.

Differential D79805

[MLIR] Fix dependencies for Analysis libraries
ClosedPublic

Authored by stephenneuendorffer on May 12 2020, 1:40 PM.

Details

Reviewers
None
Commits
rG7a17f3ccd109: [MLIR] Fix dependencies for Analysis libraries
Summary

cmake does not truly support dependencies on automatically generated files
which are not in the same directory as the targets which depend on them.
It works with ninja, but doesn't work with make

This patch adds an explicit dependence so that all dialects are built
before the analysis libraries.

Diff Detail

Event Timeline

stephenneuendorffer created this revision.May 12 2020, 1:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 12 2020, 1:40 PM
Herald added subscribers: llvm-commits, Kayjukh, frgossen and 14 others. · View Herald Transcript
This revision was not accepted when it landed; it landed in state Needs Review.May 12 2020, 2:00 PM
Closed by commit rG7a17f3ccd109: [MLIR] Fix dependencies for Analysis libraries (authored by stephenneuendorffer). · Explain Why
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B56480: Diff 263509!May 12 2020, 2:01 PM

Revision Contents

PathSize
mlir/
lib/
Analysis/
6 lines

Diff 263512

mlir/lib/Analysis/CMakeLists.txt

Show All 11 Lines
add_mlir_library(MLIRAnalysis add_mlir_library(MLIRAnalysis
CallGraph.cpp CallGraph.cpp
Liveness.cpp Liveness.cpp
SliceAnalysis.cpp SliceAnalysis.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Analysis ${MLIR_MAIN_INCLUDE_DIR}/mlir/Analysis
DEPENDS
mlir-headers
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRAffineOps MLIRAffineOps
MLIRCallInterfaces MLIRCallInterfaces
MLIRControlFlowInterfaces MLIRControlFlowInterfaces
MLIRInferTypeOpInterface MLIRInferTypeOpInterface
MLIRSCF MLIRSCF
) )
add_mlir_library(MLIRLoopAnalysis add_mlir_library(MLIRLoopAnalysis
AffineAnalysis.cpp AffineAnalysis.cpp
AffineStructures.cpp AffineStructures.cpp
LoopAnalysis.cpp LoopAnalysis.cpp
NestedMatcher.cpp NestedMatcher.cpp
Utils.cpp Utils.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Analysis ${MLIR_MAIN_INCLUDE_DIR}/mlir/Analysis
DEPENDS
mlir-headers
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRAffineOps MLIRAffineOps
MLIRCallInterfaces MLIRCallInterfaces
MLIRControlFlowInterfaces MLIRControlFlowInterfaces
MLIRInferTypeOpInterface MLIRInferTypeOpInterface
MLIRSCF MLIRSCF
) )