This is an archive of the discontinued LLVM Phabricator instance.

[YAMLVFSWriter] Add explicit assert that every file has a parent dir
Needs ReviewPublic

Authored by jkorous on May 6 2020, 10:10 PM.

Details

Reviewers
JDevlieghere
Summary

This is a leftover from me poking the code. There's an implicit assumption that every file has a parent - which if violated blows up later in implementation of containedIn(). I don't have any reasonable reproducer except adding root ("/") as file to the mapping but that doesn't make much sense.

Unsure if this should land, happy to hear opinions.

Diff Detail

Event Timeline

jkorous created this revision.May 6 2020, 10:10 PM