This is an archive of the discontinued LLVM Phabricator instance.

Add LLVM support for PPC cryptography builtins
ClosedPublic

Authored by nemanjai on Feb 27 2015, 12:38 PM.

Details

Summary

This patch is related to D7951 and adds the support in the back end. There isn't a whole lot out of the ordinary here, the builtins are provided as long as the target has FeatureP8Crypto (or FeatureP8Altivec for those instructions that do not require implementation of Category:Vector.Crypto). There are some new instruction formats, new intrinsic formats and support for a 1-bit immediate.

Diff Detail

Repository
rL LLVM

Event Timeline

nemanjai updated this revision to Diff 20882.Feb 27 2015, 12:38 PM
nemanjai retitled this revision from to Add Clang support for PPC cryptography builtins.
nemanjai updated this object.
nemanjai edited the test plan for this revision. (Show Details)
nemanjai set the repository for this revision to rL LLVM.
nemanjai added a subscriber: Unknown Object (MLST).
nemanjai retitled this revision from Add Clang support for PPC cryptography builtins to Add LLVM support for PPC cryptography builtins.Feb 27 2015, 8:22 PM
nemanjai updated this revision to Diff 21020.Mar 2 2015, 11:18 AM

Updated the test cases in response to some of the comments from the other (Clang) patch for this as well as for the new required form for the load instructions.

wschmidt edited edge metadata.Mar 2 2015, 11:50 AM

This patch LGTM, but let's let hfinkel have a look as well if he has time.

wschmidt accepted this revision.Mar 3 2015, 10:22 AM
wschmidt edited edge metadata.

Hal is traveling this week, so let's just go ahead at this point. Thanks!

This revision is now accepted and ready to land.Mar 3 2015, 10:22 AM
echristo accepted this revision.Mar 3 2015, 11:53 AM
echristo edited edge metadata.

LGTM as well.

-eric

nemanjai closed this revision.Mar 4 2015, 1:55 PM

Committed revision 231285.