This is an archive of the discontinued LLVM Phabricator instance.

Use the unified section list when generating a symbol table
ClosedPublic

Authored by labath on Feb 26 2015, 9:17 AM.

Details

Summary

Symbol table generation code was failing to take into account the debug symbols because
the object file was looking only into its own section list when doing the generation, even though
the debug symbols from another object file were correctly detected and loaded by the
SymbolVendor. This changes the code to use the unified section list, which fixes this problem.

Diff Detail

Event Timeline

labath updated this revision to Diff 20771.Feb 26 2015, 9:17 AM
labath retitled this revision from to Use the unified section list when generating a symbol table.
labath updated this object.
labath edited the test plan for this revision. (Show Details)
labath added reviewers: clayborg, zturner.
labath added a subscriber: Unknown Object (MLST).
emaste added a subscriber: emaste.Feb 26 2015, 9:25 AM
clayborg accepted this revision.Feb 26 2015, 10:18 AM
clayborg edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Feb 26 2015, 10:18 AM
This revision was automatically updated to reflect the committed changes.