This is an archive of the discontinued LLVM Phabricator instance.

Differential D78737

[libc] Link mpfr and gmp wrapper to the libcMPFRWrapper.
ClosedPublic

Authored by sivachandra on Apr 23 2020, 11:31 AM.

Details

Reviewers
PaulkaToast
Commits
rG1e2772c0a333: [libc] Link mpfr and gmp wrapper to the libcMPFRWrapper.
Summary

This will fix building the wrapper shared library when
BUILD_SHARED_LIBS is ON.

Diff Detail

Event Timeline

sivachandra created this revision.Apr 23 2020, 11:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 23 2020, 11:31 AM
Herald added subscribers: libc-commits, tschuett, mgorny. · View Herald Transcript
This revision was not accepted when it landed; it landed in state Needs Review.Apr 23 2020, 11:54 AM
Closed by commit rG1e2772c0a333: [libc] Link mpfr and gmp wrapper to the libcMPFRWrapper. (authored by sivachandra). · Explain Why
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B54450: Diff 259649!Apr 23 2020, 12:28 PM

Revision Contents

PathSize
libc/
utils/
MPFRWrapper/
1 line

Diff 259660

libc/utils/MPFRWrapper/CMakeLists.txt

try_compile( try_compile(
LIBC_TESTS_CAN_USE_MPFR LIBC_TESTS_CAN_USE_MPFR
${CMAKE_CURRENT_BINARY_DIR} ${CMAKE_CURRENT_BINARY_DIR}
SOURCES SOURCES
${CMAKE_CURRENT_SOURCE_DIR}/check_mpfr.cpp ${CMAKE_CURRENT_SOURCE_DIR}/check_mpfr.cpp
LINK_LIBRARIES LINK_LIBRARIES
-lmpfr -lgmp -lmpfr -lgmp
) )
if(LIBC_TESTS_CAN_USE_MPFR) if(LIBC_TESTS_CAN_USE_MPFR)
add_library(libcMPFRWrapper add_library(libcMPFRWrapper
MPFRUtils.cpp MPFRUtils.cpp
MPFRUtils.h MPFRUtils.h
) )
target_link_libraries(libcMPFRWrapper -lmpfr -lgmp)
else() else()
message(WARNING "Math tests using MPFR will be skipped.") message(WARNING "Math tests using MPFR will be skipped.")
endif() endif()