This is an archive of the discontinued LLVM Phabricator instance.

Differential D78700

[libc] Surround get_start_args_addr in __llvm_libc namespace.
ClosedPublic

Authored by PaulkaToast on Apr 23 2020, 4:14 AM.

Details

Reviewers
sivachandra
Commits
rGd94af364acfa: [libc] Surround get_start_args_addr in __llvm_libc namespace.
Summary

Caught by libc-tidy from patch D76818.

Diff Detail

Unit TestsFailed

TimeTest
11,420 mslldb-api.commands/expression/import-std-module/basic::Unknown Unit Message ("")
3,430 mslldb-api.commands/expression/import-std-module/conflicts::Unknown Unit Message ("")
5,680 mslldb-api.commands/expression/import-std-module/deque-basic::Unknown Unit Message ("")
5,610 mslldb-api.commands/expression/import-std-module/deque-dbg-info-content::Unknown Unit Message ("")
5,340 mslldb-api.commands/expression/import-std-module/forward_list::Unknown Unit Message ("")
View Full Test Results (41 Failed)

Event Timeline

PaulkaToast created this revision.Apr 23 2020, 4:14 AM
Herald added subscribers: libc-commits, tschuett. · View Herald TranscriptApr 23 2020, 4:14 AM
Harbormaster failed remote builds in B54378: Diff 259515!Apr 23 2020, 4:49 AM
sivachandra accepted this revision.Apr 23 2020, 9:46 AM
This revision is now accepted and ready to land.Apr 23 2020, 9:46 AM
Closed by commit rGd94af364acfa: [libc] Surround get_start_args_addr in __llvm_libc namespace. (authored by PaulkaToast). · Explain WhyApr 23 2020, 3:15 PM
This revision was automatically updated to reflect the committed changes.
PaulkaToast edited the summary of this revision. (Show Details)May 29 2020, 3:23 PM
Herald added a subscriber: ecnelises. · View Herald TranscriptMay 29 2020, 3:23 PM

Revision Contents

PathSize
libc/
src/
threads/
linux/
x86_64/
3 lines

Diff 259515

libc/src/threads/linux/x86_64/thread_start_args.h.in

//===- x86_64 implementation of the get_start_args_addr function -*- C++ -*===// //===- x86_64 implementation of the get_start_args_addr function -*- C++ -*===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
%%begin() %%begin()
namespace __llvm_libc {
__attribute__((always_inline)) inline uintptr_t get_start_args_addr() { __attribute__((always_inline)) inline uintptr_t get_start_args_addr() {
// NOTE: For __builtin_frame_address to work reliably across compilers, // NOTE: For __builtin_frame_address to work reliably across compilers,
// architectures and various optimization levels, the TU including this file // architectures and various optimization levels, the TU including this file
// should be compiled with -fno-omit-frame-pointer. // should be compiled with -fno-omit-frame-pointer.
return reinterpret_cast<uintptr_t>(__builtin_frame_address(0)) + return reinterpret_cast<uintptr_t>(__builtin_frame_address(0)) +
// The x86_64 call instruction pushes resume address on to the stack. // The x86_64 call instruction pushes resume address on to the stack.
// Next, The x86_64 SysV ABI also pushes the frame pointer on the // Next, The x86_64 SysV ABI also pushes the frame pointer on the
// stack. Hence, we look past these items to get to the start args. // stack. Hence, we look past these items to get to the start args.
sizeof(uintptr_t) * 2; sizeof(uintptr_t) * 2;
} }
} // namespace __llvm_libc