This is an archive of the discontinued LLVM Phabricator instance.

Differential D78641

[builtins] Add void prototype to unprototyped functions
ClosedPublic

Authored by aykevl on Apr 22 2020, 7:56 AM.

Details

Reviewers
scanon
ab
MaskRay
Commits
rG1109dcba20dc: [builtins] Add void prototype to unprototyped functions
Summary

This patch replaces () prototypes with (void) prototypes, to avoid declaring these functions as variadic functions.

Found while porting compiler-rt to the AVR platform. There are still some Clang bugs where it uses the wrong address space for variadic functions, and this patch works around that. Of course this should also be fixed in Clang, but I think the effort started in D78491 is a much more systematic approach (and will probably take a while until it is finished). Until then, this patch avoids some accidental variadic functions.

Diff Detail

Unit TestsFailed

TimeTest
50 msLLVM.Transforms/OpenMP::Unknown Unit Message ("")
11,550 mslldb-api.commands/expression/import-std-module/basic::Unknown Unit Message ("")
3,600 mslldb-api.commands/expression/import-std-module/conflicts::Unknown Unit Message ("")
5,670 mslldb-api.commands/expression/import-std-module/deque-basic::Unknown Unit Message ("")
5,840 mslldb-api.commands/expression/import-std-module/deque-dbg-info-content::Unknown Unit Message ("")
View Full Test Results (42 Failed)

Event Timeline

aykevl created this revision.Apr 22 2020, 7:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 22 2020, 7:56 AM
Herald added subscribers: Restricted Project, dylanmckay. · View Herald Transcript
aykevl edited the summary of this revision. (Show Details)Apr 22 2020, 7:57 AM
MaskRay accepted this revision.Apr 22 2020, 8:14 AM

LGTM. Though hope you can address more issues in one patch.

This revision is now accepted and ready to land.Apr 22 2020, 8:14 AM
Harbormaster failed remote builds in B54250: Diff 259286!Apr 22 2020, 9:12 AM
aykevl added a comment.Apr 22 2020, 12:50 PM

Thanks for the review!

In D78641#1996984, @MaskRay wrote:

LGTM. Though hope you can address more issues in one patch.

Yeah I just fixed things as I went through supporting AVR (D78205 was to get the builtins to compile, this patch was to get the tests to compile). If I find more issues, I'll try to bundle all related changes in one patch.

Closed by commit rG1109dcba20dc: [builtins] Add void prototype to unprototyped functions (authored by aykevl). · Explain WhyApr 22 2020, 1:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
compiler-rt/
test/
builtins/
Unit/
16 lines

Diff 259286

compiler-rt/test/builtins/Unit/fp_test.h

Show First 20 Lines • Show All 205 Lines • ▼ Show 20 Lines switch(expected){
case GREATER_0: case GREATER_0:
return ">0"; return ">0";
default: default:
return ""; return "";
} }
return ""; return "";
} }
static inline uint16_t makeQNaN16() static inline uint16_t makeQNaN16(void)
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-static inline uint16_t makeQNaN16(void)
-{
-    return fromRep16(0x7e00U);
+static inline uint16_t makeQNaN16(void) {
+  return fromRep16(0x7e00U);
Lint: Pre-merge checks: clang-format: please reformat the code ``` -static inline uint16_t makeQNaN16(void) -{…
{ {
return fromRep16(0x7e00U); return fromRep16(0x7e00U);
} }
static inline float makeQNaN32() static inline float makeQNaN32(void)
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-static inline float makeQNaN32(void)
-{
-    return fromRep32(0x7fc00000U);
+static inline float makeQNaN32(void) {
+  return fromRep32(0x7fc00000U);
Lint: Pre-merge checks: clang-format: please reformat the code ``` -static inline float makeQNaN32(void) -{ - return…
{ {
return fromRep32(0x7fc00000U); return fromRep32(0x7fc00000U);
} }
static inline double makeQNaN64() static inline double makeQNaN64(void)
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-static inline double makeQNaN64(void)
-{
-    return fromRep64(0x7ff8000000000000UL);
+static inline double makeQNaN64(void) {
+  return fromRep64(0x7ff8000000000000UL);
Lint: Pre-merge checks: clang-format: please reformat the code ``` -static inline double makeQNaN64(void) -{…
{ {
return fromRep64(0x7ff8000000000000UL); return fromRep64(0x7ff8000000000000UL);
} }
#if __LDBL_MANT_DIG__ == 113 #if __LDBL_MANT_DIG__ == 113
static inline long double makeQNaN128() static inline long double makeQNaN128(void)
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-static inline long double makeQNaN128(void)
-{
-    return fromRep128(0x7fff800000000000UL, 0x0UL);
+static inline long double makeQNaN128(void) {
+  return fromRep128(0x7fff800000000000UL, 0x0UL);
Lint: Pre-merge checks: clang-format: please reformat the code ``` -static inline long double makeQNaN128(void) -{…
{ {
return fromRep128(0x7fff800000000000UL, 0x0UL); return fromRep128(0x7fff800000000000UL, 0x0UL);
} }
#endif #endif
static inline uint16_t makeNaN16(uint16_t rand) static inline uint16_t makeNaN16(uint16_t rand)
{ {
return fromRep16(0x7c00U | (rand & 0x7fffU)); return fromRep16(0x7c00U | (rand & 0x7fffU));
Show All 11 Lines
#if __LDBL_MANT_DIG__ == 113 #if __LDBL_MANT_DIG__ == 113
static inline long double makeNaN128(uint64_t rand) static inline long double makeNaN128(uint64_t rand)
{ {
return fromRep128(0x7fff000000000000UL | (rand & 0xffffffffffffUL), 0x0UL); return fromRep128(0x7fff000000000000UL | (rand & 0xffffffffffffUL), 0x0UL);
} }
#endif #endif
static inline uint16_t makeInf16() static inline uint16_t makeInf16(void)
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-static inline uint16_t makeInf16(void)
-{
-    return fromRep16(0x7c00U);
+static inline uint16_t makeInf16(void) {
+  return fromRep16(0x7c00U);
Lint: Pre-merge checks: clang-format: please reformat the code ``` -static inline uint16_t makeInf16(void) -{…
{ {
return fromRep16(0x7c00U); return fromRep16(0x7c00U);
} }
static inline float makeInf32() static inline float makeInf32(void)
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-static inline float makeInf32(void)
-{
-    return fromRep32(0x7f800000U);
+static inline float makeInf32(void) {
+  return fromRep32(0x7f800000U);
Lint: Pre-merge checks: clang-format: please reformat the code ``` -static inline float makeInf32(void) -{ - return…
{ {
return fromRep32(0x7f800000U); return fromRep32(0x7f800000U);
} }
static inline double makeInf64() static inline double makeInf64(void)
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-static inline double makeInf64(void)
-{
-    return fromRep64(0x7ff0000000000000UL);
+static inline double makeInf64(void) {
+  return fromRep64(0x7ff0000000000000UL);
Lint: Pre-merge checks: clang-format: please reformat the code ``` -static inline double makeInf64(void) -{ - return…
{ {
return fromRep64(0x7ff0000000000000UL); return fromRep64(0x7ff0000000000000UL);
} }
#if __LDBL_MANT_DIG__ == 113 #if __LDBL_MANT_DIG__ == 113
static inline long double makeInf128() static inline long double makeInf128(void)
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-static inline long double makeInf128(void)
-{
-    return fromRep128(0x7fff000000000000UL, 0x0UL);
+static inline long double makeInf128(void) {
+  return fromRep128(0x7fff000000000000UL, 0x0UL);
Lint: Pre-merge checks: clang-format: please reformat the code ``` -static inline long double makeInf128(void) -{…
{ {
return fromRep128(0x7fff000000000000UL, 0x0UL); return fromRep128(0x7fff000000000000UL, 0x0UL);
} }
#endif #endif