This is an archive of the discontinued LLVM Phabricator instance.

[mlir] [linalg] Fix transform-patterns test.
ClosedPublic

Authored by poechsel on Apr 21 2020, 2:31 AM.

Details

Summary

Unfortunately FileCheck ignores directives with whitespace between the directive and the colon (CHECK : for example), thus most of the directives of this test were ignored.

Diff Detail

Event Timeline

poechsel created this revision.Apr 21 2020, 2:31 AM
ftynse accepted this revision.Apr 21 2020, 2:53 AM

Thanks!

mlir/test/Dialect/Linalg/transform-patterns.mlir
4

This looks like the stride along the last dim is known to be "1". I suppose that's what you meant by the "_1" in the name, but maybe add a comment to explain.

This revision is now accepted and ready to land.Apr 21 2020, 2:53 AM
poechsel updated this revision to Diff 258955.Apr 21 2020, 3:29 AM

Rebase + add comments over STRIDED_2D_1

poechsel marked an inline comment as done.Apr 21 2020, 3:30 AM
This revision was automatically updated to reflect the committed changes.