This is an archive of the discontinued LLVM Phabricator instance.

Update mlir for CreateShuffleVector with unsigned deprecation
ClosedPublic

Authored by echristo on Apr 20 2020, 3:04 PM.

Details

Summary

Unless you can think of a better way to do this conversion.

Diff Detail

Event Timeline

echristo created this revision.Apr 20 2020, 3:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 20 2020, 3:04 PM
jpienaar accepted this revision.Apr 20 2020, 3:26 PM

Looks good modulo variable names (e.g., postion and mask) and feel free to use [{ ... ]} form instead and or move it inside and have

let llvmBuilder = [{

as LLVM_ExtractValueOp does. If Alex has different suggestion then this can be followed up on.

This revision is now accepted and ready to land.Apr 20 2020, 3:26 PM
mehdi_amini accepted this revision.Apr 20 2020, 3:45 PM
This revision was automatically updated to reflect the committed changes.