This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Clarify operation/block assert message.
AcceptedPublic

Authored by matthiaskramm on Apr 20 2020, 9:53 AM.

Details

Reviewers
rriddle
Summary

When you try to add the same operation into a block twice, we used
to print "already in an operation block", which sounded misleading.
(Sound like e.g. our builder insertion point is inside a block.)
Instead, make it clear that the operation is being used twice.

Event Timeline

matthiaskramm created this revision.Apr 20 2020, 9:53 AM
Herald added a project: Restricted Project. · View Herald Transcript
rriddle accepted this revision.Apr 20 2020, 9:54 AM
This revision is now accepted and ready to land.Apr 20 2020, 9:54 AM