This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Use --standalone when running tests on the iOS simulator
ClosedPublic

Authored by yln on Apr 17 2020, 5:34 PM.

Details

Summary

We can use simctl spawn --standalone to enable running tests without
the need for an already-booted simulator instance. This also side-steps
the problem of not having a good place to shutdown the instance after
we are finished with testing.

rdar://58118442

Diff Detail

Event Timeline

yln created this revision.Apr 17 2020, 5:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 17 2020, 5:34 PM
Herald added subscribers: Restricted Project, dberris. · View Herald Transcript
yln updated this revision to Diff 258457.Apr 17 2020, 5:41 PM

Also remove check for env var.

yln marked an inline comment as done.Apr 17 2020, 5:43 PM
yln added inline comments.
compiler-rt/test/sanitizer_common/ios_commands/iossim_prepare.py
10

Note that we still have this check in iossim_run.py.

kubamracek accepted this revision.Apr 17 2020, 8:10 PM
This revision is now accepted and ready to land.Apr 17 2020, 8:10 PM
delcypher accepted this revision.Apr 17 2020, 11:05 PM
This revision was automatically updated to reflect the committed changes.