This is an archive of the discontinued LLVM Phabricator instance.

[dfsan] Remove realloc from done_abilist.txt
ClosedPublic

Authored by EliaGeretto on Apr 17 2020, 9:02 AM.

Download Raw Diff

Details

Reviewers

kcc
pcc
vitalybuka

Commits

rGd059d01c23e4: [dfsan] Remove realloc from done_abilist.txt

Summary

Currently, realloc is marked as "discard" in done_abilist.txt. As discussed in PR#45583, this is probably not the expected behavior; a custom wrapper seems to be required. Since this wrapper has not been implemented yet, realloc should not be in the done_abilist.txt file so that a warning is displayed when it is called.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

EliaGeretto created this revision.Apr 17 2020, 9:02 AM

Herald added a project: Restricted Project. · View Herald TranscriptApr 17 2020, 9:02 AM

Herald added a subscriber: Restricted Project. · View Herald Transcript

Harbormaster failed remote builds in B53735: Diff 258345!Apr 17 2020, 9:10 AM

The failure in the CI does not appear to be related to my change, but to an infrastructure problem. At least that is what it looks like.

Harbormaster completed remote builds in B53735: Diff 258345.Apr 26 2020, 9:33 AM

Ping.

vitalybuka accepted this revision.May 5 2020, 1:16 AM

This revision is now accepted and ready to land.May 5 2020, 1:16 AM

@vitalybuka Thank you for your review. Also, I do not have commit access, so someone else needs to commit the change for me.

Closed by commit rGd059d01c23e4: [dfsan] Remove realloc from done_abilist.txt (authored by vitalybuka). · Explain WhyMay 5 2020, 10:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

compiler-rt/

lib/

dfsan/

done_abilist.txt

1 line

Diff 262292

compiler-rt/lib/dfsan/done_abilist.txt

	Show All 27 Lines
	fun:dfsan_set_write_callback=custom			fun:dfsan_set_write_callback=custom
	fun:dfsan_flush=uninstrumented			fun:dfsan_flush=uninstrumented
	fun:dfsan_flush=discard			fun:dfsan_flush=discard

	###############################################################################			###############################################################################
	# glibc			# glibc
	###############################################################################			###############################################################################
	fun:malloc=discard			fun:malloc=discard
	fun:realloc=discard
	fun:free=discard			fun:free=discard

	# Functions that return a value that depends on the input, but the output might			# Functions that return a value that depends on the input, but the output might
	# not be necessarily data-dependent on the input.			# not be necessarily data-dependent on the input.
	fun:isalpha=functional			fun:isalpha=functional
	fun:isdigit=functional			fun:isdigit=functional
	fun:isprint=functional			fun:isprint=functional
	fun:isxdigit=functional			fun:isxdigit=functional
	▲ Show 20 Lines • Show All 263 Lines • Show Last 20 Lines