Page MenuHomePhabricator

EliaGeretto (Elia Geretto)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 18 2019, 2:20 AM (53 w, 12 h)

Recent Activity

May 5 2020

EliaGeretto added a comment to D78379: [dfsan] Remove realloc from done_abilist.txt.

@vitalybuka Thank you for your review. Also, I do not have commit access, so someone else needs to commit the change for me.

May 5 2020, 2:06 AM · Restricted Project
EliaGeretto added a comment to D78379: [dfsan] Remove realloc from done_abilist.txt.

Ping.

May 5 2020, 1:02 AM · Restricted Project

Apr 26 2020

EliaGeretto added a comment to D78379: [dfsan] Remove realloc from done_abilist.txt.

Ping.

Apr 26 2020, 10:37 AM · Restricted Project

Apr 17 2020

EliaGeretto added a comment to D78379: [dfsan] Remove realloc from done_abilist.txt.

The failure in the CI does not appear to be related to my change, but to an infrastructure problem. At least that is what it looks like.

Apr 17 2020, 9:42 AM · Restricted Project
EliaGeretto created D78379: [dfsan] Remove realloc from done_abilist.txt.
Apr 17 2020, 9:09 AM · Restricted Project

Jan 27 2020

EliaGeretto added a comment to D71959: [PassManagerBuilder] Remove global extension when a plugin is unloaded.

@Meinersbur @serge-sans-paille I have quickly taken a look at the other pull request and yes, it seems a fix for the exact same problem, discussed in PR39321.

Jan 27 2020, 12:43 PM · Restricted Project

Jan 26 2020

EliaGeretto added a comment to D71959: [PassManagerBuilder] Remove global extension when a plugin is unloaded.

@mehdi_amini Thank you for your review. I wanted to let you know that I do not have commit access, so someone else should commit this change for me. In addition, I think that this change could be backported to older LLVM releases, at least those that still get bugfixes. The bug addressed here is around since LLVM 5 it seems, as discussed here: https://bugs.llvm.org/show_bug.cgi?id=39321

Jan 26 2020, 1:54 AM · Restricted Project
EliaGeretto updated the diff for D71959: [PassManagerBuilder] Remove global extension when a plugin is unloaded.

removeGlobalExtension now early-exits when GlobalExtensions is not constructed and uses llvm::find_if to iterate over the collection.

Jan 26 2020, 1:41 AM · Restricted Project

Jan 24 2020

EliaGeretto added a comment to D71959: [PassManagerBuilder] Remove global extension when a plugin is unloaded.

Ping.

Jan 24 2020, 2:37 AM · Restricted Project

Jan 17 2020

EliaGeretto added a comment to D71959: [PassManagerBuilder] Remove global extension when a plugin is unloaded.

Ping.

Jan 17 2020, 7:36 AM · Restricted Project

Jan 10 2020

EliaGeretto added a comment to D71959: [PassManagerBuilder] Remove global extension when a plugin is unloaded.

Ping.

Jan 10 2020, 2:59 AM · Restricted Project

Dec 29 2019

EliaGeretto updated the diff for D71959: [PassManagerBuilder] Remove global extension when a plugin is unloaded.

I have added comments to explain the reason of some of the changes and added an assert so that, if the removeGlobalExtension function is called with an invalid ID, the error will be more noticeable.

Dec 29 2019, 10:43 AM · Restricted Project
EliaGeretto added inline comments to D71959: [PassManagerBuilder] Remove global extension when a plugin is unloaded.
Dec 29 2019, 6:52 AM · Restricted Project
EliaGeretto updated the summary of D71959: [PassManagerBuilder] Remove global extension when a plugin is unloaded.
Dec 29 2019, 6:52 AM · Restricted Project

Dec 28 2019

EliaGeretto created D71959: [PassManagerBuilder] Remove global extension when a plugin is unloaded.
Dec 28 2019, 5:52 AM · Restricted Project