Page MenuHomePhabricator

[clang] Fix invalid comparator in tablegen
ClosedPublic

Authored by EricWF on Apr 16 2020, 12:53 PM.

Details

Summary

The current version of the comparator does not introduce a strict weak ordering.

Diff Detail

Event Timeline

EricWF created this revision.Apr 16 2020, 12:53 PM
Herald added a project: Restricted Project. ยท View Herald TranscriptApr 16 2020, 12:53 PM
sdesmalen accepted this revision.Apr 16 2020, 1:45 PM

LGTM, did this comparison introduce any non-determinism?

This revision is now accepted and ready to land.Apr 16 2020, 1:45 PM

LGTM, did this comparison introduce any non-determinism?

Potentially, but I observed the issue using libc++'s debug mode.
I'm unsure if the current inputs would have caused libc++ to read past the end of the vector.