This is an archive of the discontinued LLVM Phabricator instance.

[AVR] Define __ELF__
ClosedPublic

Authored by aykevl on Apr 14 2020, 8:36 AM.

Details

Summary

This symbol is defined in avr-gcc. Because AVR normally uses the ELF format, define the symbol unconditionally.

This patch is needed to get Clang to compile compiler-rt.

Diff Detail

Event Timeline

aykevl created this revision.Apr 14 2020, 8:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 14 2020, 8:36 AM
aykevl updated this revision to Diff 257358.Apr 14 2020, 8:47 AM

The test/clang/Preprocessor/ directory may make more sense for such tests. Is it time to create a target-specific sub directory test/clang/Preprocessor/AVR/?

Harbormaster completed remote builds in B53153: Diff 257358.
rjmccall accepted this revision.Apr 14 2020, 12:47 PM

I agree that these tests are in the wrong directory; please prepare a patch that moves them. This patch is okay to go, though.

This revision is now accepted and ready to land.Apr 14 2020, 12:47 PM
This revision was automatically updated to reflect the committed changes.

Okay, I have committed this patch and created a new patch to move the files: https://reviews.llvm.org/D78163