Page MenuHomePhabricator

[NFC, tsan] Update tsan tests expectation
ClosedPublic

Authored by pratyai on Apr 14 2020, 8:23 AM.

Details

Summary

These tests pass with clang, but fail if gcc was used.
gcc build creates similar but not the same stacks.

Diff Detail

Event Timeline

pratyai created this revision.Apr 14 2020, 8:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 14 2020, 8:23 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
pratyai added a subscriber: llvm-commits.

this patch is going to break tests where ever it passes now

How exactly do you configure the project? And what is the platform.
For me tests pass as-is and fail with your patch.

pratyai added a comment.EditedApr 14 2020, 11:48 PM

How exactly do you configure the project? And what is the platform.
For me tests pass as-is and fail with your patch.

configuration:
cmake -G Ninja -DLLVM_ENABLE_PROJECTS="clang;clang-tools-extra;compiler-rt;lld" -DCOMPILER_RT_BUILD_LIBFUZZER=ON ../llvm

platform:
x86_64
installed clang version 8.0.1-4

Right; they started to appear in check-all after I configured the fuzzer; I thought it just added new things to build and check.

I'm okay with dropping this diff; however this 5 tests and another 3 from other parts of the project fails with the configuration above^. It would be convenient to avoid that if possible, but I can ignore a few known failures from check-all results too.

vitalybuka added a subscriber: dvyukov.EditedApr 16 2020, 4:29 PM

I see, I can reproduce if I drop
-DCMAKE_C_COMPILER=something/bin/clang -DCMAKE_CXX_COMPILER=something/bin/clang++
So when runtime is compiled with gcc, so the stack is a little bit different.

I think it's fine relax the test and just check something like

CHECK: #0 {{(memcpy|memmove)}}
CHECK: #{{[12]}} Thread2

vitalybuka accepted this revision.Apr 16 2020, 5:02 PM

I'll update and land it

This revision is now accepted and ready to land.Apr 16 2020, 5:02 PM
vitalybuka retitled this revision from Update check-tsan tests to reflect the interceptor code to Update check-tsan tests to make it work with gcc.Apr 16 2020, 5:05 PM
vitalybuka edited the summary of this revision. (Show Details)
vitalybuka retitled this revision from Update check-tsan tests to make it work with gcc to [NFC, tsan] Update tsan tests expectation.Apr 16 2020, 5:08 PM
vitalybuka edited the summary of this revision. (Show Details)

relax tests

This revision was automatically updated to reflect the committed changes.