These tests pass with clang, but fail if gcc was used.
gcc build creates similar but not the same stacks.
Details
- Reviewers
vitalybuka - Commits
- rGa1526cd62b67: [NFC, tsan] Update tsan tests expectation
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
How exactly do you configure the project? And what is the platform.
For me tests pass as-is and fail with your patch.
configuration:
cmake -G Ninja -DLLVM_ENABLE_PROJECTS="clang;clang-tools-extra;compiler-rt;lld" -DCOMPILER_RT_BUILD_LIBFUZZER=ON ../llvm
platform:
x86_64
installed clang version 8.0.1-4
Right; they started to appear in check-all after I configured the fuzzer; I thought it just added new things to build and check.
I'm okay with dropping this diff; however this 5 tests and another 3 from other parts of the project fails with the configuration above^. It would be convenient to avoid that if possible, but I can ignore a few known failures from check-all results too.
I see, I can reproduce if I drop
-DCMAKE_C_COMPILER=something/bin/clang -DCMAKE_CXX_COMPILER=something/bin/clang++
So when runtime is compiled with gcc, so the stack is a little bit different.
I think it's fine relax the test and just check something like
CHECK: #0 {{(memcpy|memmove)}}
CHECK: #{{[12]}} Thread2