Page MenuHomePhabricator

Fix the MLIR integer attribute parser to be correct in the face of large integer attributes, it was previously artificially limited to 64 bits.
ClosedPublic

Authored by lattner on Apr 13 2020, 4:37 PM.

Diff Detail

Unit TestsFailed

TimeTest
90 msMLIR.Target::Unknown Unit Message ("")
Script: -- : 'RUN: at line 1'; c:\ws\workspace\amd64_windows_vs2017\llvm-project\build\bin\mlir-translate.exe -mlir-to-llvmir C:\ws\workspace\amd64_windows_vs2017\llvm-project\mlir\test\Target\llvmir.mlir | c:\ws\workspace\amd64_windows_vs2017\llvm-project\build\bin\filecheck.exe C:\ws\workspace\amd64_windows_vs2017\llvm-project\mlir\test\Target\llvmir.mlir
50 msMLIR.Target::Unknown Unit Message ("")
Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/workspace/BETA_amd64_debian_testing_clang8/llvm-project/build/bin/mlir-translate -mlir-to-llvmir /mnt/disks/ssd0/agent/workspace/BETA_amd64_debian_testing_clang8/llvm-project/mlir/test/Target/llvmir.mlir | /mnt/disks/ssd0/agent/workspace/BETA_amd64_debian_testing_clang8/llvm-project/build/bin/FileCheck /mnt/disks/ssd0/agent/workspace/BETA_amd64_debian_testing_clang8/llvm-project/mlir/test/Target/llvmir.mlir

Event Timeline

lattner created this revision.Apr 13 2020, 4:37 PM
Herald added a project: Restricted Project. · View Herald Transcript
lattner updated this revision to Diff 257148.Apr 13 2020, 4:41 PM
lattner marked an inline comment as done.

Fix two minor things caught in self-review.

The test failures are unrelated to my change.

rriddle accepted this revision.Apr 13 2020, 6:11 PM
This revision is now accepted and ready to land.Apr 13 2020, 6:11 PM
lattner closed this revision.Apr 13 2020, 9:51 PM

Thanks for the review!