This is an archive of the discontinued LLVM Phabricator instance.

[Alignment][NFC] Transition to MachineFrameInfo::getObjectAlign()
AbandonedPublic

Authored by kaz7 on Apr 8 2020, 12:11 AM.

Download Raw Diff

Details

Reviewers

simoll
k-ishizaka

Summary

This is additional changes to https://reviews.llvm.org/D77215

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

kaz7 created this revision.Apr 8 2020, 12:11 AM

Herald added subscribers: llvm-commits, hiraditya. · View Herald TranscriptApr 8 2020, 12:11 AM

LGTM

This has already been fixed by commit 624654f

This revision is now accepted and ready to land.Apr 8 2020, 12:50 AM

This problem is fixed in 624654fd647057dd6c1cdf8799a7605b69716a02 already. Thanks.

Harbormaster failed remote builds in B52305: Diff 255912!Apr 8 2020, 1:02 AM

Revision Contents

Path

Size

llvm/

lib/

Target/

VE/

VEInstrInfo.cpp

4 lines

Diff 255912

llvm/lib/Target/VE/VEInstrInfo.cpp

//===-- VEInstrInfo.cpp - VE Instruction Information ----------------------===//		//===-- VEInstrInfo.cpp - VE Instruction Information ----------------------===//
		Lint: Lint Inline Actions clang-format not found in user's PATH; not linting file. Lint: Lint: clang-format not found in user's PATH; not linting file.
//		//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.		// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.		// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception		// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//		//
//===----------------------------------------------------------------------===//		//===----------------------------------------------------------------------===//
//		//
▲ Show 20 Lines • Show All 337 Lines • ▼ Show 20 Lines	void VEInstrInfo::storeRegToStackSlot(MachineBasicBlock &MBB,
DebugLoc DL;		DebugLoc DL;
if (I != MBB.end())		if (I != MBB.end())
DL = I->getDebugLoc();		DL = I->getDebugLoc();

MachineFunction *MF = MBB.getParent();		MachineFunction *MF = MBB.getParent();
const MachineFrameInfo &MFI = MF->getFrameInfo();		const MachineFrameInfo &MFI = MF->getFrameInfo();
MachineMemOperand *MMO = MF->getMachineMemOperand(		MachineMemOperand *MMO = MF->getMachineMemOperand(
MachinePointerInfo::getFixedStack(*MF, FI), MachineMemOperand::MOStore,		MachinePointerInfo::getFixedStack(*MF, FI), MachineMemOperand::MOStore,
MFI.getObjectSize(FI), MFI.getObjectAlignment(FI));		MFI.getObjectSize(FI), MFI.getObjectAlign(FI));

// On the order of operands here: think "[FrameIdx + 0] = SrcReg".		// On the order of operands here: think "[FrameIdx + 0] = SrcReg".
if (RC == &VE::I64RegClass) {		if (RC == &VE::I64RegClass) {
BuildMI(MBB, I, DL, get(VE::STrii))		BuildMI(MBB, I, DL, get(VE::STrii))
.addFrameIndex(FI)		.addFrameIndex(FI)
.addImm(0)		.addImm(0)
.addImm(0)		.addImm(0)
.addReg(SrcReg, getKillRegState(isKill))		.addReg(SrcReg, getKillRegState(isKill))
Show All 24 Lines	void VEInstrInfo::loadRegFromStackSlot(MachineBasicBlock &MBB,
DebugLoc DL;		DebugLoc DL;
if (I != MBB.end())		if (I != MBB.end())
DL = I->getDebugLoc();		DL = I->getDebugLoc();

MachineFunction *MF = MBB.getParent();		MachineFunction *MF = MBB.getParent();
const MachineFrameInfo &MFI = MF->getFrameInfo();		const MachineFrameInfo &MFI = MF->getFrameInfo();
MachineMemOperand *MMO = MF->getMachineMemOperand(		MachineMemOperand *MMO = MF->getMachineMemOperand(
MachinePointerInfo::getFixedStack(*MF, FI), MachineMemOperand::MOLoad,		MachinePointerInfo::getFixedStack(*MF, FI), MachineMemOperand::MOLoad,
MFI.getObjectSize(FI), MFI.getObjectAlignment(FI));		MFI.getObjectSize(FI), MFI.getObjectAlign(FI));

if (RC == &VE::I64RegClass) {		if (RC == &VE::I64RegClass) {
BuildMI(MBB, I, DL, get(VE::LDrii), DestReg)		BuildMI(MBB, I, DL, get(VE::LDrii), DestReg)
.addFrameIndex(FI)		.addFrameIndex(FI)
.addImm(0)		.addImm(0)
.addImm(0)		.addImm(0)
.addMemOperand(MMO);		.addMemOperand(MMO);
} else if (RC == &VE::I32RegClass) {		} else if (RC == &VE::I32RegClass) {
▲ Show 20 Lines • Show All 130 Lines • Show Last 20 Lines