This is an archive of the discontinued LLVM Phabricator instance.

[VE] Simplify definitions of uimm6 and simm7
ClosedPublic

Authored by kaz7 on Apr 7 2020, 6:33 PM.

Details

Summary

To prepare continuous changes, simplify uimm6 and simm7 operands.

Diff Detail

Event Timeline

kaz7 created this revision.Apr 7 2020, 6:33 PM
kaz7 updated this revision to Diff 255883.Apr 7 2020, 8:16 PM

Update to run check-llvm correctly. I had a problem on my test environment
and I didn't notice check-llvm errors.

Good catch!
Minor nit. Otw, LGTM.

llvm/lib/Target/VE/VEInstrInfo.td
29

How come there is a DecoderMethod for simm7 but not for uimm6? I am not saying this is wrong but i'd like to understand why this works.

kaz7 marked an inline comment as done.Apr 8 2020, 12:30 AM
kaz7 added inline comments.
llvm/lib/Target/VE/VEInstrInfo.td
29

We don't need decoder functions for unsigned values since the default decoder method works correctly for unsigned immediate values. In order to sign-extend values, we need particular functions.

simoll accepted this revision.Apr 8 2020, 12:52 AM

Thanks. LGTM.

llvm/lib/Target/VE/VEInstrInfo.td
29

I see

This revision is now accepted and ready to land.Apr 8 2020, 12:52 AM
This revision was automatically updated to reflect the committed changes.