[InstCombine] exclude bitcast of ppc_fp128 in icmp signbit fold

[spatel]

Summary

Based on the post-commit comments for rG0f56bbc, there might be a problem with this transform:

(bitcast (fpext/fptrunc X)) to iX) < 0 --> (bitcast X to iY) < 0

...and the ppc_fp128 data type, so conservatively bypass if we are bitcasting a ppc_fp128.

[spatel]

Patch updated:
Add code comment to better explain the transform and PPC limitation.

[echristo]

LGTM for now :)

llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp

if (Bitcast->getSrcTy()->getScalarSizeInBits() ==
     // Zero-equality checks are preserved through unsigned floating-point casts:
     // icmp eq (bitcast (uitofp X)), 0 --> icmp eq X, 0
     // icmp ne (bitcast (uitofp X)), 0 --> icmp ne X, 0
     if (match(BCSrcOp, m_UIToFP(m_Value(X))))
       if (Cmp.isEquality() && match(Op1, m_Zero()))
         return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType()));
 
     // If this is a sign-bit test of a bitcast of a casted FP value, eliminate
-    // the FP cast because the FP cast does not change the sign-bit.
+    // the FP extend/truncate because that cast does not change the sign-bit.
+    // This is true for all standard IEEE-754 types and the X86 80-bit type.
+    // The sign-bit is always the most significant bit in those types.
     const APInt *C;
     bool TrueIfSigned;
-    if (match(Op1, m_APInt(C)) && Bitcast->hasOneUse() &&
-        isSignBitCheck(Pred, *C, TrueIfSigned)) {
+    if (!BCSrcOp->getType()->isPPC_FP128Ty() && match(Op1, m_APInt(C)) &&
+        Bitcast->hasOneUse() && isSignBitCheck(Pred, *C, TrueIfSigned)) {
       if (match(BCSrcOp, m_FPExt(m_Value(X))) ||
           match(BCSrcOp, m_FPTrunc(m_Value(X)))) {
         // (bitcast (fpext/fptrunc X)) to iX) < 0 --> (bitcast X to iY) < 0
         // (bitcast (fpext/fptrunc X)) to iX) > -1 --> (bitcast X to iY) > -1
         Type *XType = X->getType();
         Type *NewType = Builder.getIntNTy(XType->getScalarSizeInBits());
         if (XType->isVectorTy())
           NewType = VectorType::get(NewType, XType->getVectorNumElements());

llvm/test/Transforms/InstCombine/icmp.ll

;
   %b = bitcast double %f to i64
   call void @use_i64(i64 %b)
   %r = icmp slt i64 %b, 0
   ret i1 %r
 }
 
 define i1 @signbit_bitcast_fpext_ppc_fp128(float %x) {
 ; CHECK-LABEL: @signbit_bitcast_fpext_ppc_fp128(
-; CHECK-NEXT:    [[TMP1:%.*]] = bitcast float [[X:%.*]] to i32
-; CHECK-NEXT:    [[S4:%.*]] = icmp slt i32 [[TMP1]], 0
+; CHECK-NEXT:    [[S2:%.*]] = fpext float [[X:%.*]] to ppc_fp128
+; CHECK-NEXT:    [[S3:%.*]] = bitcast ppc_fp128 [[S2]] to i128
+; CHECK-NEXT:    [[S4:%.*]] = icmp slt i128 [[S3]], 0
 ; CHECK-NEXT:    ret i1 [[S4]]
 ;
   %s2 = fpext float %x to ppc_fp128
   %s3 = bitcast ppc_fp128 %s2 to i128
   %s4 = icmp slt i128 %s3, 0
   ret i1 %s4
 }