This is an archive of the discontinued LLVM Phabricator instance.

Differential D77625

Fix a typo in the error message for an incorrect prototype.
ClosedPublic

Authored by Jean-Luc on Apr 6 2020, 8:01 PM.

Details

Reviewers
matthiaskramm
Commits
rG9b1a0d300e5e: Fix a typo in the error message for an incorrect prototype.
Summary

Cut & paste error had the error message mentionning "}" rather than ")".

Diff Detail

Event Timeline

Jean-Luc created this revision.Apr 6 2020, 8:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 6 2020, 8:01 PM
Herald added subscribers: llvm-commits, grosul1, Joonsoo and 11 others. · View Herald Transcript
Jean-Luc added a reviewer: matthiaskramm.Apr 6 2020, 8:03 PM
Harbormaster completed remote builds in B52100: Diff 255572.Apr 6 2020, 8:44 PM
matthiaskramm accepted this revision.Apr 7 2020, 6:06 AM

Thanks for fixing this!

This revision is now accepted and ready to land.Apr 7 2020, 6:06 AM
Closed by commit rG9b1a0d300e5e: Fix a typo in the error message for an incorrect prototype. (authored by Jean-Luc, committed by rriddle). · Explain WhyApr 13 2020, 3:47 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: frgossen. · View Herald TranscriptApr 13 2020, 3:47 PM

Revision Contents

PathSize
mlir/
examples/
toy/
Ch1/
include/
toy/
2 lines
Ch2/
include/
toy/
2 lines
Ch3/
include/
toy/
2 lines
Ch4/
include/
toy/
2 lines
Ch5/
include/
toy/
2 lines
Ch6/
include/
toy/
2 lines
Ch7/
include/
toy/
2 lines

Diff 257131

mlir/examples/toy/Ch1/include/toy/Parser.h

Show First 20 Lines • Show All 422 Lines • ▼ Show 20 Lines if (lexer.getCurToken() != ')') {
break; break;
lexer.consume(Token(',')); lexer.consume(Token(','));
if (lexer.getCurToken() != tok_identifier) if (lexer.getCurToken() != tok_identifier)
return parseError<PrototypeAST>( return parseError<PrototypeAST>(
"identifier", "after ',' in function parameter list"); "identifier", "after ',' in function parameter list");
} while (true); } while (true);
} }
if (lexer.getCurToken() != ')') if (lexer.getCurToken() != ')')
return parseError<PrototypeAST>("}", "to end function prototype"); return parseError<PrototypeAST>(")", "to end function prototype");
// success. // success.
lexer.consume(Token(')')); lexer.consume(Token(')'));
return std::make_unique<PrototypeAST>(std::move(loc), fnName, return std::make_unique<PrototypeAST>(std::move(loc), fnName,
std::move(args)); std::move(args));
} }
/// Parse a function definition, we expect a prototype initiated with the /// Parse a function definition, we expect a prototype initiated with the
▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines

mlir/examples/toy/Ch2/include/toy/Parser.h

Show First 20 Lines • Show All 422 Lines • ▼ Show 20 Lines if (lexer.getCurToken() != ')') {
break; break;
lexer.consume(Token(',')); lexer.consume(Token(','));
if (lexer.getCurToken() != tok_identifier) if (lexer.getCurToken() != tok_identifier)
return parseError<PrototypeAST>( return parseError<PrototypeAST>(
"identifier", "after ',' in function parameter list"); "identifier", "after ',' in function parameter list");
} while (true); } while (true);
} }
if (lexer.getCurToken() != ')') if (lexer.getCurToken() != ')')
return parseError<PrototypeAST>("}", "to end function prototype"); return parseError<PrototypeAST>(")", "to end function prototype");
// success. // success.
lexer.consume(Token(')')); lexer.consume(Token(')'));
return std::make_unique<PrototypeAST>(std::move(loc), fnName, return std::make_unique<PrototypeAST>(std::move(loc), fnName,
std::move(args)); std::move(args));
} }
/// Parse a function definition, we expect a prototype initiated with the /// Parse a function definition, we expect a prototype initiated with the
▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines

mlir/examples/toy/Ch3/include/toy/Parser.h

Show First 20 Lines • Show All 422 Lines • ▼ Show 20 Lines if (lexer.getCurToken() != ')') {
break; break;
lexer.consume(Token(',')); lexer.consume(Token(','));
if (lexer.getCurToken() != tok_identifier) if (lexer.getCurToken() != tok_identifier)
return parseError<PrototypeAST>( return parseError<PrototypeAST>(
"identifier", "after ',' in function parameter list"); "identifier", "after ',' in function parameter list");
} while (true); } while (true);
} }
if (lexer.getCurToken() != ')') if (lexer.getCurToken() != ')')
return parseError<PrototypeAST>("}", "to end function prototype"); return parseError<PrototypeAST>(")", "to end function prototype");
// success. // success.
lexer.consume(Token(')')); lexer.consume(Token(')'));
return std::make_unique<PrototypeAST>(std::move(loc), fnName, return std::make_unique<PrototypeAST>(std::move(loc), fnName,
std::move(args)); std::move(args));
} }
/// Parse a function definition, we expect a prototype initiated with the /// Parse a function definition, we expect a prototype initiated with the
▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines

mlir/examples/toy/Ch4/include/toy/Parser.h

Show First 20 Lines • Show All 422 Lines • ▼ Show 20 Lines if (lexer.getCurToken() != ')') {
break; break;
lexer.consume(Token(',')); lexer.consume(Token(','));
if (lexer.getCurToken() != tok_identifier) if (lexer.getCurToken() != tok_identifier)
return parseError<PrototypeAST>( return parseError<PrototypeAST>(
"identifier", "after ',' in function parameter list"); "identifier", "after ',' in function parameter list");
} while (true); } while (true);
} }
if (lexer.getCurToken() != ')') if (lexer.getCurToken() != ')')
return parseError<PrototypeAST>("}", "to end function prototype"); return parseError<PrototypeAST>(")", "to end function prototype");
// success. // success.
lexer.consume(Token(')')); lexer.consume(Token(')'));
return std::make_unique<PrototypeAST>(std::move(loc), fnName, return std::make_unique<PrototypeAST>(std::move(loc), fnName,
std::move(args)); std::move(args));
} }
/// Parse a function definition, we expect a prototype initiated with the /// Parse a function definition, we expect a prototype initiated with the
▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines

mlir/examples/toy/Ch5/include/toy/Parser.h

Show First 20 Lines • Show All 422 Lines • ▼ Show 20 Lines if (lexer.getCurToken() != ')') {
break; break;
lexer.consume(Token(',')); lexer.consume(Token(','));
if (lexer.getCurToken() != tok_identifier) if (lexer.getCurToken() != tok_identifier)
return parseError<PrototypeAST>( return parseError<PrototypeAST>(
"identifier", "after ',' in function parameter list"); "identifier", "after ',' in function parameter list");
} while (true); } while (true);
} }
if (lexer.getCurToken() != ')') if (lexer.getCurToken() != ')')
return parseError<PrototypeAST>("}", "to end function prototype"); return parseError<PrototypeAST>(")", "to end function prototype");
// success. // success.
lexer.consume(Token(')')); lexer.consume(Token(')'));
return std::make_unique<PrototypeAST>(std::move(loc), fnName, return std::make_unique<PrototypeAST>(std::move(loc), fnName,
std::move(args)); std::move(args));
} }
/// Parse a function definition, we expect a prototype initiated with the /// Parse a function definition, we expect a prototype initiated with the
▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines

mlir/examples/toy/Ch6/include/toy/Parser.h

Show First 20 Lines • Show All 422 Lines • ▼ Show 20 Lines if (lexer.getCurToken() != ')') {
break; break;
lexer.consume(Token(',')); lexer.consume(Token(','));
if (lexer.getCurToken() != tok_identifier) if (lexer.getCurToken() != tok_identifier)
return parseError<PrototypeAST>( return parseError<PrototypeAST>(
"identifier", "after ',' in function parameter list"); "identifier", "after ',' in function parameter list");
} while (true); } while (true);
} }
if (lexer.getCurToken() != ')') if (lexer.getCurToken() != ')')
return parseError<PrototypeAST>("}", "to end function prototype"); return parseError<PrototypeAST>(")", "to end function prototype");
// success. // success.
lexer.consume(Token(')')); lexer.consume(Token(')'));
return std::make_unique<PrototypeAST>(std::move(loc), fnName, return std::make_unique<PrototypeAST>(std::move(loc), fnName,
std::move(args)); std::move(args));
} }
/// Parse a function definition, we expect a prototype initiated with the /// Parse a function definition, we expect a prototype initiated with the
▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines

mlir/examples/toy/Ch7/include/toy/Parser.h

Show First 20 Lines • Show All 577 Lines • ▼ Show 20 Lines if (lexer.getCurToken() != ')') {
break; break;
lexer.consume(Token(',')); lexer.consume(Token(','));
if (lexer.getCurToken() != tok_identifier) if (lexer.getCurToken() != tok_identifier)
return parseError<PrototypeAST>( return parseError<PrototypeAST>(
"identifier", "after ',' in function parameter list"); "identifier", "after ',' in function parameter list");
} while (true); } while (true);
} }
if (lexer.getCurToken() != ')') if (lexer.getCurToken() != ')')
return parseError<PrototypeAST>("}", "to end function prototype"); return parseError<PrototypeAST>(")", "to end function prototype");
// success. // success.
lexer.consume(Token(')')); lexer.consume(Token(')'));
return std::make_unique<PrototypeAST>(std::move(loc), fnName, return std::make_unique<PrototypeAST>(std::move(loc), fnName,
std::move(args)); std::move(args));
} }
/// Parse a function definition, we expect a prototype initiated with the /// Parse a function definition, we expect a prototype initiated with the
▲ Show 20 Lines • Show All 89 Lines • Show Last 20 Lines