This is an archive of the discontinued LLVM Phabricator instance.

Differential D77510

[mlir] Only number the parent operation in Block::printAsOperand
ClosedPublic

Authored by rriddle on Apr 5 2020, 12:16 PM.

Details

Reviewers
mehdi_amini
Commits
rGc9da04d6604d: [mlir] Only number the parent operation in Block::printAsOperand
Summary

Blocks are numbered locally within a region, so numbering above the parent region is unnecessary.

Diff Detail

Event Timeline

rriddle created this revision.Apr 5 2020, 12:16 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 5 2020, 12:16 PM
Herald added subscribers: llvm-commits, grosul1, Joonsoo and 9 others. · View Herald Transcript
Harbormaster completed remote builds in B51855: Diff 255183.Apr 5 2020, 12:48 PM
mehdi_amini accepted this revision.Apr 5 2020, 4:12 PM
This revision is now accepted and ready to land.Apr 5 2020, 4:12 PM
Closed by commit rGc9da04d6604d: [mlir] Only number the parent operation in Block::printAsOperand (authored by rriddle). · Explain WhyApr 5 2020, 4:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
mlir/
lib/
IR/
4 lines

Diff 255183

mlir/lib/IR/AsmPrinter.cpp

//===- AsmPrinter.cpp - MLIR Assembly Printer Implementation --------------===// //===- AsmPrinter.cpp - MLIR Assembly Printer Implementation --------------===//
Lint: Lint
Inline Actions

clang-format-diff not found in user's PATH; not linting file.

Lint: Lint: clang-format-diff not found in user's PATH; not linting file.
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
▲ Show 20 Lines • Show All 2,379 Lines • ▼ Show 20 Lines
/// Print out the name of the block without printing its body. /// Print out the name of the block without printing its body.
void Block::printAsOperand(raw_ostream &os, bool printType) { void Block::printAsOperand(raw_ostream &os, bool printType) {
Operation *parentOp = getParentOp(); Operation *parentOp = getParentOp();
if (!parentOp) { if (!parentOp) {
os << "<<UNLINKED BLOCK>>\n"; os << "<<UNLINKED BLOCK>>\n";
return; return;
} }
// Get the top-level op.
while (auto *nextOp = parentOp->getParentOp())
parentOp = nextOp;
AsmState state(parentOp); AsmState state(parentOp);
printAsOperand(os, state); printAsOperand(os, state);
} }
void Block::printAsOperand(raw_ostream &os, AsmState &state) { void Block::printAsOperand(raw_ostream &os, AsmState &state) {
OperationPrinter printer(os, /*flags=*/llvm::None, state.getImpl()); OperationPrinter printer(os, /*flags=*/llvm::None, state.getImpl());
printer.printBlockName(this); printer.printBlockName(this);
} }
Show All 13 Lines