This is an archive of the discontinued LLVM Phabricator instance.

Differential D77397

Fix typos in toy tutorial
ClosedPublic

Authored by frgossen on Apr 3 2020, 7:24 AM.

Details

Reviewers
herhut
mehdi_amini
Commits
rG0f37454c7238: Fix typos in toy tutorial
Summary

Fix two typos throughout the chapters.

Diff Detail

Event Timeline

frgossen created this revision.Apr 3 2020, 7:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 3 2020, 7:24 AM
Herald added subscribers: llvm-commits, grosul1, Joonsoo and 11 others. · View Herald Transcript
frgossen added a reviewer: herhut.Apr 3 2020, 7:32 AM
Harbormaster failed remote builds in B51635: Diff 254795!Apr 3 2020, 8:02 AM
mehdi_amini accepted this revision.Apr 3 2020, 8:16 PM
This revision is now accepted and ready to land.Apr 3 2020, 8:16 PM
Closed by commit rG0f37454c7238: Fix typos in toy tutorial (authored by frgossen, committed by mehdi_amini). · Explain WhyApr 3 2020, 8:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
mlir/
examples/
toy/
Ch2/
mlir/
8 lines
Ch3/
mlir/
8 lines
Ch4/
mlir/
8 lines
Ch5/
mlir/
8 lines
Ch6/
mlir/
8 lines
Ch7/
mlir/
8 lines

Diff 254997

mlir/examples/toy/Ch2/mlir/MLIRGen.cpp

Show First 20 Lines • Show All 307 Lines • ▼ Show 20 Lines mlir::Value mlirGen(CallExprAST &call) {
SmallVector<mlir::Value, 4> operands; SmallVector<mlir::Value, 4> operands;
for (auto &expr : call.getArgs()) { for (auto &expr : call.getArgs()) {
auto arg = mlirGen(*expr); auto arg = mlirGen(*expr);
if (!arg) if (!arg)
return nullptr; return nullptr;
operands.push_back(arg); operands.push_back(arg);
} }
// Builting calls have their custom operation, meaning this is a // Builtin calls have their custom operation, meaning this is a
// straightforward emission. // straightforward emission.
if (callee == "transpose") { if (callee == "transpose") {
if (call.getArgs().size() != 1) { if (call.getArgs().size() != 1) {
emitError(location, "MLIR codegen encountered an error: toy.transpose " emitError(location, "MLIR codegen encountered an error: toy.transpose "
"does not accept multiple arguments"); "does not accept multiple arguments");
return nullptr; return nullptr;
} }
return builder.create<TransposeOp>(location, operands[0]); return builder.create<TransposeOp>(location, operands[0]);
} }
// Otherwise this is a call to a user-defined function. Calls to ser-defined // Otherwise this is a call to a user-defined function. Calls to
// functions are mapped to a custom call that takes the callee name as an // user-defined functions are mapped to a custom call that takes the callee
// attribute. // name as an attribute.
return builder.create<GenericCallOp>(location, callee, operands); return builder.create<GenericCallOp>(location, callee, operands);
} }
/// Emit a print expression. It emits specific operations for two builtins: /// Emit a print expression. It emits specific operations for two builtins:
/// transpose(x) and print(x). /// transpose(x) and print(x).
mlir::LogicalResult mlirGen(PrintExprAST &call) { mlir::LogicalResult mlirGen(PrintExprAST &call) {
auto arg = mlirGen(*call.getArg()); auto arg = mlirGen(*call.getArg());
if (!arg) if (!arg)
▲ Show 20 Lines • Show All 115 Lines • Show Last 20 Lines

mlir/examples/toy/Ch3/mlir/MLIRGen.cpp

Show First 20 Lines • Show All 307 Lines • ▼ Show 20 Lines mlir::Value mlirGen(CallExprAST &call) {
SmallVector<mlir::Value, 4> operands; SmallVector<mlir::Value, 4> operands;
for (auto &expr : call.getArgs()) { for (auto &expr : call.getArgs()) {
auto arg = mlirGen(*expr); auto arg = mlirGen(*expr);
if (!arg) if (!arg)
return nullptr; return nullptr;
operands.push_back(arg); operands.push_back(arg);
} }
// Builting calls have their custom operation, meaning this is a // Builtin calls have their custom operation, meaning this is a
// straightforward emission. // straightforward emission.
if (callee == "transpose") { if (callee == "transpose") {
if (call.getArgs().size() != 1) { if (call.getArgs().size() != 1) {
emitError(location, "MLIR codegen encountered an error: toy.transpose " emitError(location, "MLIR codegen encountered an error: toy.transpose "
"does not accept multiple arguments"); "does not accept multiple arguments");
return nullptr; return nullptr;
} }
return builder.create<TransposeOp>(location, operands[0]); return builder.create<TransposeOp>(location, operands[0]);
} }
// Otherwise this is a call to a user-defined function. Calls to ser-defined // Otherwise this is a call to a user-defined function. Calls to
// functions are mapped to a custom call that takes the callee name as an // user-defined functions are mapped to a custom call that takes the callee
// attribute. // name as an attribute.
return builder.create<GenericCallOp>(location, callee, operands); return builder.create<GenericCallOp>(location, callee, operands);
} }
/// Emit a print expression. It emits specific operations for two builtins: /// Emit a print expression. It emits specific operations for two builtins:
/// transpose(x) and print(x). /// transpose(x) and print(x).
mlir::LogicalResult mlirGen(PrintExprAST &call) { mlir::LogicalResult mlirGen(PrintExprAST &call) {
auto arg = mlirGen(*call.getArg()); auto arg = mlirGen(*call.getArg());
if (!arg) if (!arg)
▲ Show 20 Lines • Show All 115 Lines • Show Last 20 Lines

mlir/examples/toy/Ch4/mlir/MLIRGen.cpp

Show First 20 Lines • Show All 311 Lines • ▼ Show 20 Lines mlir::Value mlirGen(CallExprAST &call) {
SmallVector<mlir::Value, 4> operands; SmallVector<mlir::Value, 4> operands;
for (auto &expr : call.getArgs()) { for (auto &expr : call.getArgs()) {
auto arg = mlirGen(*expr); auto arg = mlirGen(*expr);
if (!arg) if (!arg)
return nullptr; return nullptr;
operands.push_back(arg); operands.push_back(arg);
} }
// Builting calls have their custom operation, meaning this is a // Builtin calls have their custom operation, meaning this is a
// straightforward emission. // straightforward emission.
if (callee == "transpose") { if (callee == "transpose") {
if (call.getArgs().size() != 1) { if (call.getArgs().size() != 1) {
emitError(location, "MLIR codegen encountered an error: toy.transpose " emitError(location, "MLIR codegen encountered an error: toy.transpose "
"does not accept multiple arguments"); "does not accept multiple arguments");
return nullptr; return nullptr;
} }
return builder.create<TransposeOp>(location, operands[0]); return builder.create<TransposeOp>(location, operands[0]);
} }
// Otherwise this is a call to a user-defined function. Calls to ser-defined // Otherwise this is a call to a user-defined function. Calls to
// functions are mapped to a custom call that takes the callee name as an // user-defined functions are mapped to a custom call that takes the callee
// attribute. // name as an attribute.
return builder.create<GenericCallOp>(location, callee, operands); return builder.create<GenericCallOp>(location, callee, operands);
} }
/// Emit a print expression. It emits specific operations for two builtins: /// Emit a print expression. It emits specific operations for two builtins:
/// transpose(x) and print(x). /// transpose(x) and print(x).
mlir::LogicalResult mlirGen(PrintExprAST &call) { mlir::LogicalResult mlirGen(PrintExprAST &call) {
auto arg = mlirGen(*call.getArg()); auto arg = mlirGen(*call.getArg());
if (!arg) if (!arg)
▲ Show 20 Lines • Show All 115 Lines • Show Last 20 Lines

mlir/examples/toy/Ch5/mlir/MLIRGen.cpp

Show First 20 Lines • Show All 311 Lines • ▼ Show 20 Lines mlir::Value mlirGen(CallExprAST &call) {
SmallVector<mlir::Value, 4> operands; SmallVector<mlir::Value, 4> operands;
for (auto &expr : call.getArgs()) { for (auto &expr : call.getArgs()) {
auto arg = mlirGen(*expr); auto arg = mlirGen(*expr);
if (!arg) if (!arg)
return nullptr; return nullptr;
operands.push_back(arg); operands.push_back(arg);
} }
// Builting calls have their custom operation, meaning this is a // Builtin calls have their custom operation, meaning this is a
// straightforward emission. // straightforward emission.
if (callee == "transpose") { if (callee == "transpose") {
if (call.getArgs().size() != 1) { if (call.getArgs().size() != 1) {
emitError(location, "MLIR codegen encountered an error: toy.transpose " emitError(location, "MLIR codegen encountered an error: toy.transpose "
"does not accept multiple arguments"); "does not accept multiple arguments");
return nullptr; return nullptr;
} }
return builder.create<TransposeOp>(location, operands[0]); return builder.create<TransposeOp>(location, operands[0]);
} }
// Otherwise this is a call to a user-defined function. Calls to ser-defined // Otherwise this is a call to a user-defined function. Calls to
// functions are mapped to a custom call that takes the callee name as an // user-defined functions are mapped to a custom call that takes the callee
// attribute. // name as an attribute.
return builder.create<GenericCallOp>(location, callee, operands); return builder.create<GenericCallOp>(location, callee, operands);
} }
/// Emit a print expression. It emits specific operations for two builtins: /// Emit a print expression. It emits specific operations for two builtins:
/// transpose(x) and print(x). /// transpose(x) and print(x).
mlir::LogicalResult mlirGen(PrintExprAST &call) { mlir::LogicalResult mlirGen(PrintExprAST &call) {
auto arg = mlirGen(*call.getArg()); auto arg = mlirGen(*call.getArg());
if (!arg) if (!arg)
▲ Show 20 Lines • Show All 115 Lines • Show Last 20 Lines

mlir/examples/toy/Ch6/mlir/MLIRGen.cpp

Show First 20 Lines • Show All 311 Lines • ▼ Show 20 Lines mlir::Value mlirGen(CallExprAST &call) {
SmallVector<mlir::Value, 4> operands; SmallVector<mlir::Value, 4> operands;
for (auto &expr : call.getArgs()) { for (auto &expr : call.getArgs()) {
auto arg = mlirGen(*expr); auto arg = mlirGen(*expr);
if (!arg) if (!arg)
return nullptr; return nullptr;
operands.push_back(arg); operands.push_back(arg);
} }
// Builting calls have their custom operation, meaning this is a // Builtin calls have their custom operation, meaning this is a
// straightforward emission. // straightforward emission.
if (callee == "transpose") { if (callee == "transpose") {
if (call.getArgs().size() != 1) { if (call.getArgs().size() != 1) {
emitError(location, "MLIR codegen encountered an error: toy.transpose " emitError(location, "MLIR codegen encountered an error: toy.transpose "
"does not accept multiple arguments"); "does not accept multiple arguments");
return nullptr; return nullptr;
} }
return builder.create<TransposeOp>(location, operands[0]); return builder.create<TransposeOp>(location, operands[0]);
} }
// Otherwise this is a call to a user-defined function. Calls to ser-defined // Otherwise this is a call to a user-defined function. Calls to
// functions are mapped to a custom call that takes the callee name as an // user-defined functions are mapped to a custom call that takes the callee
// attribute. // name as an attribute.
return builder.create<GenericCallOp>(location, callee, operands); return builder.create<GenericCallOp>(location, callee, operands);
} }
/// Emit a print expression. It emits specific operations for two builtins: /// Emit a print expression. It emits specific operations for two builtins:
/// transpose(x) and print(x). /// transpose(x) and print(x).
mlir::LogicalResult mlirGen(PrintExprAST &call) { mlir::LogicalResult mlirGen(PrintExprAST &call) {
auto arg = mlirGen(*call.getArg()); auto arg = mlirGen(*call.getArg());
if (!arg) if (!arg)
▲ Show 20 Lines • Show All 115 Lines • Show Last 20 Lines

mlir/examples/toy/Ch7/mlir/MLIRGen.cpp

Show First 20 Lines • Show All 495 Lines • ▼ Show 20 Lines mlir::Value mlirGen(CallExprAST &call) {
SmallVector<mlir::Value, 4> operands; SmallVector<mlir::Value, 4> operands;
for (auto &expr : call.getArgs()) { for (auto &expr : call.getArgs()) {
auto arg = mlirGen(*expr); auto arg = mlirGen(*expr);
if (!arg) if (!arg)
return nullptr; return nullptr;
operands.push_back(arg); operands.push_back(arg);
} }
// Builting calls have their custom operation, meaning this is a // Builtin calls have their custom operation, meaning this is a
// straightforward emission. // straightforward emission.
if (callee == "transpose") { if (callee == "transpose") {
if (call.getArgs().size() != 1) { if (call.getArgs().size() != 1) {
emitError(location, "MLIR codegen encountered an error: toy.transpose " emitError(location, "MLIR codegen encountered an error: toy.transpose "
"does not accept multiple arguments"); "does not accept multiple arguments");
return nullptr; return nullptr;
} }
return builder.create<TransposeOp>(location, operands[0]); return builder.create<TransposeOp>(location, operands[0]);
} }
// Otherwise this is a call to a user-defined function. Calls to ser-defined // Otherwise this is a call to a user-defined function. Calls to
// functions are mapped to a custom call that takes the callee name as an // user-defined functions are mapped to a custom call that takes the callee
// attribute. // name as an attribute.
auto calledFuncIt = functionMap.find(callee); auto calledFuncIt = functionMap.find(callee);
if (calledFuncIt == functionMap.end()) { if (calledFuncIt == functionMap.end()) {
emitError(location) << "no defined function found for '" << callee << "'"; emitError(location) << "no defined function found for '" << callee << "'";
return nullptr; return nullptr;
} }
mlir::FuncOp calledFunc = calledFuncIt->second; mlir::FuncOp calledFunc = calledFuncIt->second;
return builder.create<GenericCallOp>( return builder.create<GenericCallOp>(
location, calledFunc.getType().getResult(0), location, calledFunc.getType().getResult(0),
▲ Show 20 Lines • Show All 153 Lines • Show Last 20 Lines