Page MenuHomePhabricator

Fix __builtin_amdgcn_workgroup_size_x/y/z return type
ClosedPublic

Authored by yaxunl on Apr 3 2020, 6:27 AM.

Details

Reviewers
b-sumner
arsenm

Diff Detail

Event Timeline

yaxunl created this revision.Apr 3 2020, 6:27 AM
arsenm accepted this revision.Apr 3 2020, 6:38 AM
This revision is now accepted and ready to land.Apr 3 2020, 6:38 AM
JonChesterfield added inline comments.
clang/test/CodeGenOpenCL/builtins-amdgcn.cl
541

This looks unrelated to the return type change

yaxunl marked 2 inline comments as done.Apr 11 2020, 6:46 PM
yaxunl added inline comments.
clang/test/CodeGenOpenCL/builtins-amdgcn.cl
541

Without that change, the builtin return type is wrong and clang does not insert conversion for this "add" operation and causes assertion. Therefore this small change makes sure that error will not happen again.