Page MenuHomePhabricator

[Alignment][NFC] Mark IRTranslator::getMemOpAlignment deprecated
ClosedPublic

Authored by gchatelet on Apr 1 2020, 7:34 AM.

Details

Summary

This is patch is part of a series to introduce an Alignment type.
See this thread for context: http://lists.llvm.org/pipermail/llvm-dev/2019-July/133851.html
See this patch for the introduction of the type: https://reviews.llvm.org/D64790

Diff Detail

Event Timeline

gchatelet created this revision.Apr 1 2020, 7:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 1 2020, 7:34 AM
courbet accepted this revision.Apr 1 2020, 7:34 AM
This revision is now accepted and ready to land.Apr 1 2020, 7:34 AM
This revision was automatically updated to reflect the committed changes.
arsenm added a subscriber: arsenm.Apr 1 2020, 7:49 AM
arsenm added inline comments.
llvm/include/llvm/CodeGen/GlobalISel/IRTranslator.h
585–589

The number of uses in GlobalISel is so small, there's no reason to bother with this. It should be trivial to eliminate the old forms

gchatelet marked 2 inline comments as done.Apr 2 2020, 1:44 AM
gchatelet added inline comments.
llvm/include/llvm/CodeGen/GlobalISel/IRTranslator.h
585–589

Are you sure it's not used by out of tree users?
If so, I'm happy to drop it.

My plan is to start removing LLVM_ATTRIBUTE_DEPRECATED functions that have been introduced in the last release.