[AVR] Fix function pointer address space

[vlastik]

Summary

Function pointers should be created with program address space.
This fixes function pointers on AVR.

[vlastik]

Fix formatting

[dylanmckay]

Nice work @vlastik, do you need someone to commit this for you?

[vlastik]

In D77119#1952293, @dylanmckay wrote:

Nice work @vlastik, do you need someone to commit this for you?

Thanks, yes please I need someone to commit the patch

clang/lib/CodeGen/CodeGenTypes.cpp

case Type::RValueReference: {
     break;
   }
   case Type::Pointer: {
     const PointerType *PTy = cast<PointerType>(Ty);
     QualType ETy = PTy->getPointeeType();
     llvm::Type *PointeeType = ConvertTypeForMem(ETy);
     if (PointeeType->isVoidTy())
       PointeeType = llvm::Type::getInt8Ty(getLLVMContext());
-    unsigned AS = Context.getTargetAddressSpace(ETy);
+
+    unsigned AS = PointeeType->isFunctionTy()
+                      ? getDataLayout().getProgramAddressSpace()
+                      : Context.getTargetAddressSpace(ETy);
+
     ResultType = llvm::PointerType::get(PointeeType, AS);
     break;
   }
 
   case Type::VariableArray: {
     const VariableArrayType *A = cast<VariableArrayType>(Ty);
     assert(A->getIndexTypeCVRQualifiers() == 0 &&
            "FIXME: We only handle trivial array types so far!");