Page MenuHomePhabricator

[MLIR] Rename collapsePLoops -> collapseParallelLoops
ClosedPublic

Authored by tpopp on Mar 30 2020, 4:50 AM.

Details

Summary

Additionally, NFC code cleanups were done.

This is to address additional comments on
https://reviews.llvm.org/D76363

Diff Detail

Event Timeline

tpopp created this revision.Mar 30 2020, 4:50 AM
bondhugula accepted this revision.Mar 30 2020, 9:19 AM
bondhugula added inline comments.
mlir/lib/Transforms/Utils/LoopUtils.cpp
1229

inner.getBody() to avoid confusion since this is a single block region.

This revision is now accepted and ready to land.Mar 30 2020, 9:19 AM
tpopp marked an inline comment as done.Mar 30 2020, 10:03 AM
tpopp added inline comments.
mlir/lib/Transforms/Utils/LoopUtils.cpp
1229

I'll block this on whatever happens with https://reviews.llvm.org/D77060

There's an annoying detail right now that constructing an OpBuilder on a Block vs Region create different insertion points (end() and begin()) respectively, so I'll revert this line and another below if it resolves in a different way, or do as you suggest here if it lands.

tpopp marked 2 inline comments as done.Apr 1 2020, 1:16 AM
tpopp added inline comments.
mlir/lib/Transforms/Utils/LoopUtils.cpp
1229

This is now OpBuilder::atBlockBegin() in order to be more explicit.

This revision was automatically updated to reflect the committed changes.