This is an archive of the discontinued LLVM Phabricator instance.

Only add `darwin_log_cmd` lit shell test feature when the log can be queried.
ClosedPublic

Authored by delcypher on Mar 26 2020, 6:28 PM.

Details

Summary

Follow up fix to 445b810fbd4. The log show command only works for
privileged users so run a quick test of the command during lit config to
see if the command works and only add the darwin_log_cmd feature if
this is the case.

Unfortunately this means the asan/TestCases/Darwin/duplicate_os_log_reports.cpp
test and any other tests in the future that use this feature won't run
for unprivileged users which is likely the case in CI.

rdar://problem/55986279

Diff Detail

Event Timeline

delcypher created this revision.Mar 26 2020, 6:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 26 2020, 6:28 PM
Herald added subscribers: Restricted Project, Charusso. · View Herald Transcript
yln accepted this revision.Mar 27 2020, 10:17 AM
This revision is now accepted and ready to land.Mar 27 2020, 10:17 AM

@yln Thanks for the review!

This revision was automatically updated to reflect the committed changes.