Page MenuHomePhabricator

Move setBugReportMsg() out from under a conditional
ClosedPublic

Authored by probinson on Mar 26 2020, 4:02 PM.

Details

Summary

Fixes a build break with LLVM_ENABLE_BACKTRACES=OFF.

Diff Detail

Event Timeline

probinson created this revision.Mar 26 2020, 4:02 PM

For some reason my git environment is hosed and I can't commit this directly at the moment.
@leonardchan go ahead and commit this.

MaskRay accepted this revision.Mar 26 2020, 4:29 PM
MaskRay added a subscriber: MaskRay.

I am doing internal integrates and have also read the source. This looks good.

This revision is now accepted and ready to land.Mar 26 2020, 4:29 PM
leonardchan accepted this revision.Mar 26 2020, 4:37 PM

LGTM. Thanks for the fix. I'll go ahead and submit this.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 26 2020, 4:53 PM

LGTM. Thanks for the fix. I'll go ahead and submit this.

You should have done git commit --amend --author='Paul Robinson <...>' to credit this change properly to Paul.

LGTM. Thanks for the fix. I'll go ahead and submit this.

You should have done git commit --amend --author='Paul Robinson <...>' to credit this change properly to Paul.

My bad. I'll keep this in mind for the future.