This is an archive of the discontinued LLVM Phabricator instance.

[libomptarget] Add missing elf_end call in elf_common.c
ClosedPublic

Authored by JonChesterfield on Mar 26 2020, 11:27 AM.

Reviewers

Commits

Summary

[libomptarget] Add missing elf_end call in elf_common.c
Noticed when reviewing D76843.

Nice catch! Thanks!

This revision is now accepted and ready to land.Mar 26 2020, 12:03 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

openmp/

libomptarget/

plugins/

common/

1 line

Show All 39 Lines	static inline int32_t elf_check_machine(__tgt_device_image *image,
if (!e) {		if (!e) {
DP("Unable to get ELF handle: %s!\n", elf_errmsg(-1));		DP("Unable to get ELF handle: %s!\n", elf_errmsg(-1));
return 0;		return 0;
}		}

// Check if ELF is the right kind.		// Check if ELF is the right kind.
if (elf_kind(e) != ELF_K_ELF) {		if (elf_kind(e) != ELF_K_ELF) {
DP("Unexpected ELF type!\n");		DP("Unexpected ELF type!\n");
		elf_end(e);
return 0;		return 0;
}		}
Elf64_Ehdr *eh64 = elf64_getehdr(e);		Elf64_Ehdr *eh64 = elf64_getehdr(e);
Elf32_Ehdr *eh32 = elf32_getehdr(e);		Elf32_Ehdr *eh32 = elf32_getehdr(e);

if (!eh64 && !eh32) {		if (!eh64 && !eh32) {
DP("Unable to get machine ID from ELF file!\n");		DP("Unable to get machine ID from ELF file!\n");
elf_end(e);		elf_end(e);
Show All 17 Lines