This is an archive of the discontinued LLVM Phabricator instance.

Differential D76763

Export Segment.IsGapRegion to JSON
ClosedPublic

Authored by def on Mar 25 2020, 4:06 AM.

Details

Reviewers
vsk
Commits
rGaa0be69e7408: Export Segment.IsGapRegion to JSON
Summary

So that external tools can make use of that information and not display such lines as uncovered.

Fixes https://bugs.llvm.org/show_bug.cgi?id=45300

Diff Detail

Event Timeline

def created this revision.Mar 25 2020, 4:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 25 2020, 4:06 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster failed remote builds in B50376: Diff 252535!Mar 25 2020, 4:50 AM
def updated this revision to Diff 252543.Mar 25 2020, 4:51 AM

Fixed clang-format

vsk added a comment.Mar 25 2020, 10:09 AM

Thanks for doing this. Yes, I think a patch version bump would be appropriate. Also, please update test/tools/llvm-cov/Inputs/binary-formats.canonical.json to test this change.

def updated this revision to Diff 252766.Mar 26 2020, 1:25 AM
def edited the summary of this revision. (Show Details)

Increased the json export version to 2.0.1, fixed binary-formats.canonical.json

vsk accepted this revision.Mar 26 2020, 9:46 AM

Lgtm, thanks.

This revision is now accepted and ready to land.Mar 26 2020, 9:46 AM
Closed by commit rGaa0be69e7408: Export Segment.IsGapRegion to JSON (authored by def, committed by aaronpuchert). · Explain WhyMar 27 2020, 10:21 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
tools/
llvm-cov/
2 lines

Diff 252535

llvm/tools/llvm-cov/CoverageExporterJson.cpp

Context not available.
json::Array renderSegment(const coverage::CoverageSegment &Segment) { json::Array renderSegment(const coverage::CoverageSegment &Segment) {
return json::Array({Segment.Line, Segment.Col, clamp_uint64_to_int64(Segment.Count), return json::Array({Segment.Line, Segment.Col, clamp_uint64_to_int64(Segment.Count),
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  return json::Array({Segment.Line, Segment.Col, clamp_uint64_to_int64(Segment.Count),
-                      Segment.HasCount, Segment.IsRegionEntry, Segment.IsGapRegion});
+  return json::Array({Segment.Line, Segment.Col,
+                      clamp_uint64_to_int64(Segment.Count), Segment.HasCount,
+                      Segment.IsRegionEntry, Segment.IsGapRegion});
Lint: Pre-merge checks: clang-format: please reformat the code ``` - return json::Array({Segment.Line, Segment.Col…
Segment.HasCount, Segment.IsRegionEntry}); Segment.HasCount, Segment.IsRegionEntry, Segment.IsGapRegion});
} }
json::Array renderRegion(const coverage::CountedRegion &Region) { json::Array renderRegion(const coverage::CountedRegion &Region) {
Context not available.