Page MenuHomePhabricator

[Utils][FIX] Properly deal with occasionally deleted functions
ClosedPublic

Authored by jdoerfert on Sun, Mar 22, 10:58 PM.

Details

Summary

While D68850 allowed functions to be deleted I accidentally saved some
version of the function to be used once a suitable prefix was found.
This turned out to be problematic when the occasionally deleted function
is also occasionally modified. The test case is adjusted to resemble the
case in which the problem was found.

Diff Detail

Event Timeline

jdoerfert created this revision.Sun, Mar 22, 10:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptSun, Mar 22, 10:58 PM
lebedev.ri accepted this revision.Thu, Mar 26, 11:41 AM

Seems reasonable to me.

This revision is now accepted and ready to land.Thu, Mar 26, 11:41 AM
This revision was automatically updated to reflect the committed changes.