This is an archive of the discontinued LLVM Phabricator instance.

Differential D76566

MergeFunctions.rst - multiply vs shift typo (PR44717)
ClosedPublic

Authored by RKSimon on Mar 22 2020, 8:18 AM.

Details

Reviewers
jonatan1626
hiraditya
dyatkovskiy
Commits
rG6a6a83c6e9bf: MergeFunctions.rst - multiply vs shift typo (PR44717)
Summary

The doc is suggesting that a mul-by-2 is the same as a ashr-by-1 instead of shl-by-1

Diff Detail

Event Timeline

RKSimon created this revision.Mar 22 2020, 8:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 22 2020, 8:18 AM
Harbormaster completed remote builds in B50028: Diff 251889.Mar 22 2020, 9:04 AM
hiraditya accepted this revision.Mar 22 2020, 4:26 PM
This revision is now accepted and ready to land.Mar 22 2020, 4:26 PM
Closed by commit rG6a6a83c6e9bf: MergeFunctions.rst - multiply vs shift typo (PR44717) (authored by RKSimon). · Explain WhyMar 23 2020, 3:15 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
docs/
4 lines

Diff 251889

llvm/docs/MergeFunctions.rst

Show First 20 Lines • Show All 93 Lines • ▼ Show 20 Lines
integer, while another one stores a pointer. If the target is the machine integer, while another one stores a pointer. If the target is the machine
mentioned above, and if functions are identical, except the parameter type (we mentioned above, and if functions are identical, except the parameter type (we
could consider it as a part of function type), then we can treat a ``uint64_t`` could consider it as a part of function type), then we can treat a ``uint64_t``
and a ``void*`` as equal. and a ``void*`` as equal.
This is just an example; more possible details are described a bit below. This is just an example; more possible details are described a bit below.
As another example, the reader may imagine two more functions. The first As another example, the reader may imagine two more functions. The first
function performs a multiplication on 2, while the second one performs an function performs a multiplication by 2, while the second one performs an
arithmetic right shift on 1. logical left shift by 1.
Possible solutions Possible solutions
^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^
Let's briefly consider possible options about how and what we have to implement Let's briefly consider possible options about how and what we have to implement
in order to create full-featured functions merging, and also what it would in order to create full-featured functions merging, and also what it would
mean for us. mean for us.
Equal function detection obviously supposes that a "detector" method to be Equal function detection obviously supposes that a "detector" method to be
▲ Show 20 Lines • Show All 674 Lines • Show Last 20 Lines