This is an archive of the discontinued LLVM Phabricator instance.

[Syntax] Split syntax tests
ClosedPublic

Authored by hlopko on Mar 18 2020, 8:00 AM.

Details

Summary

This patch split Basic test into multple individual tests to allow simpler
filtering and clearer signal into what's broken when it's broken.

Diff Detail

Event Timeline

hlopko created this revision.Mar 18 2020, 8:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 18 2020, 8:00 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
gribozavr2 accepted this revision.Mar 18 2020, 8:39 AM
gribozavr2 added inline comments.
clang/unittests/Tooling/Syntax/TreeTest.cpp
643

"using directive"

665

The construct in this test is called a "using declaration".

1420

SP -> Sp

1649

"Complex declarator"?

1685

"Complex declarator"?

This revision is now accepted and ready to land.Mar 18 2020, 8:39 AM
hlopko updated this revision to Diff 251102.Mar 18 2020, 8:47 AM
hlopko marked 5 inline comments as done.

Renaming some tests.

Addressed comments.

This revision was automatically updated to reflect the committed changes.