Page MenuHomePhabricator

[DEXTER] Add step.UNKNOWN check to DexTer for None valued steps.
ClosedPublic

Authored by TWeaver on Mar 11 2020, 7:40 AM.

Details

Summary

Add unknown step check for null linenos, visual studio debuggers, when debugging an executable produced by clang-cl.exe, are stepping onto lines in main where they cannot recover line number information but is still considered a valid step.

a later step-type check would try to compare a line number with a None value with an int and systematically crash out.

This is a fix for Dexter whereby any steps that are recorded that don't have line number information are classed as step.UNKNOWNS.

Diff Detail

Event Timeline

TWeaver created this revision.Mar 11 2020, 7:40 AM
Orlando accepted this revision.Mar 11 2020, 8:59 AM

LGTM.

debuginfo-tests/dexter/dex/dextIR/DextIR.py
117

While we're here is column ever None?

This revision is now accepted and ready to land.Mar 11 2020, 8:59 AM
TWeaver added inline comments.Mar 11 2020, 9:48 AM
debuginfo-tests/dexter/dex/dextIR/DextIR.py
117

in this case path, lineno and column are all none. The only valid step information is the function name.

TWeaver marked an inline comment as done.Mar 11 2020, 9:51 AM
TWeaver added inline comments.
debuginfo-tests/dexter/dex/dextIR/DextIR.py
117

'this case' i.e. the motivating case that produced this change. This is the minimum I need to continue working with dexter atm.

TWeaver marked an inline comment as not done.Mar 11 2020, 9:54 AM
Orlando added inline comments.Mar 11 2020, 10:43 AM
debuginfo-tests/dexter/dex/dextIR/DextIR.py
117

in this case path, lineno and column are all none

Since column can be None then, it may be worth adding similar check? Either way still LGTM.

TWeaver added inline comments.Mar 11 2020, 12:58 PM
debuginfo-tests/dexter/dex/dextIR/DextIR.py
117

could do... there's two potential definitions. if we stay on the same line but don't know the column movement would you class that as SAME or as UNKNOWN?

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 16 2020, 9:49 AM