[mlir] Add derived attribute op interface

[jpienaar]

Summary

Interface provides uniform access to the the derived attribute query method.

[rriddle]

mlir/include/mlir/Analysis/DerivedAttributeOpInterface.h

2 ↗

(On Diff #249465)

Can we move this to the newly added Interfaces/ directory?

17 ↗

(On Diff #249465)

I believe you should only need OpDefinition.h here.

mlir/include/mlir/Analysis/DerivedAttributeOpInterface.td

20 ↗

(On Diff #249465)

Can you provide more detail here on what derived attributes are?

[jpienaar]

Moved to interfaces directory.

[jpienaar]

forgot cmakefile ...

[jpienaar]

Updated, thanks

[rriddle]

mlir/include/mlir/Interfaces/CMakeLists.txt

13

Looks like you are missing the accompanying .cpp file and the necessary CMake changes, i.e. nothing seems to include DerivedAttributeOpInterface.cpp.inc

mlir/include/mlir/Interfaces/DerivedAttributeOpInterface.h

21

This needs to be updated.

mlir/include/mlir/Interfaces/DerivedAttributeOpInterface.td

23

typo: stotred

30

nit: string -> name

[jpienaar]

adding more missing files

mlir/include/mlir/Interfaces/CMakeLists.txt

13

D'oh, seems I should probably avoid operating heavy machinery today ...

[rriddle]

mlir/lib/Interfaces/DerivedAttributeOpInterface.cpp

17

Note: this isn't strictly necessary given 'using namespace mlir'.

mlir/include/mlir/Interfaces/CMakeLists.txt

 set(LLVM_TARGET_DEFINITIONS CallInterfaces.td)
 mlir_tablegen(CallInterfaces.h.inc -gen-op-interface-decls)
 mlir_tablegen(CallInterfaces.cpp.inc -gen-op-interface-defs)
 add_public_tablegen_target(MLIRCallInterfacesIncGen)
 
 set(LLVM_TARGET_DEFINITIONS ControlFlowInterfaces.td)
 mlir_tablegen(ControlFlowInterfaces.h.inc -gen-op-interface-decls)
 mlir_tablegen(ControlFlowInterfaces.cpp.inc -gen-op-interface-defs)
 add_public_tablegen_target(MLIRControlFlowInterfacesIncGen)
 
+set(LLVM_TARGET_DEFINITIONS DerivedAttributeOpInterface.td)
+mlir_tablegen(DerivedAttributeOpInterface.h.inc -gen-op-interface-decls)
+mlir_tablegen(DerivedAttributeOpInterface.cpp.inc -gen-op-interface-defs)
+add_public_tablegen_target(MLIRDerivedAttributeOpInterfaceIncGen)
+
 set(LLVM_TARGET_DEFINITIONS InferTypeOpInterface.td)
 mlir_tablegen(InferTypeOpInterface.h.inc -gen-op-interface-decls)
 mlir_tablegen(InferTypeOpInterface.cpp.inc -gen-op-interface-defs)
 add_public_tablegen_target(MLIRInferTypeOpInterfaceIncGen)
 
 set(LLVM_TARGET_DEFINITIONS SideEffects.td)
 mlir_tablegen(SideEffectInterfaces.h.inc -gen-op-interface-decls)
 mlir_tablegen(SideEffectInterfaces.cpp.inc -gen-op-interface-defs)
 add_public_tablegen_target(MLIRSideEffectOpInterfacesIncGen)

mlir/include/mlir/Interfaces/DerivedAttributeOpInterface.h

+//===- DerivedAttributeOpInterface.h ----------------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+//
+// This file contains a set of interfaces for derived attribute op interface.
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef MLIR_INTERFACES_DERIVEDATTRIBUTEOPINTERFACE_H_
+#define MLIR_INTERFACES_DERIVEDATTRIBUTEOPINTERFACE_H_
+
+#include "mlir/IR/OpDefinition.h"
+
+namespace mlir {
+#include "mlir/Interfaces/DerivedAttributeOpInterface.h.inc"
+} // namespace mlir
+
+#endif // MLIR_INTERFACES_DERIVEDATTRIBUTEOPINTERFACE_H_

mlir/include/mlir/Interfaces/DerivedAttributeOpInterface.td

+//===- DerivedAttributeOpInterface.td ----------------------*- tablegen -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+//
+// This file contains a set of interfaces for derived attribute op interface.
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef MLIR_DERIVEDATTRIBUTEOPINTERFACE
+#define MLIR_DERIVEDATTRIBUTEOPINTERFACE
+
+include "mlir/IR/OpBase.td"
+
+def DerivedAttributeOpInterface : OpInterface<"DerivedAttributeOpInterface"> {
+  let description = [{
+    Interface to query derived attribute characteristics.
+
+    Derived attributes are not stored in the operation but are instead derived
+    from information of the operation. ODS generates convenience accessors for
+    derived attributes and can be used to simplify translations.
+  }];
+
+  let methods = [
+    StaticInterfaceMethod<
+      /*desc=*/"Returns whether name corresponds to a derived attribute.",
+      /*retTy=*/"bool",
+      /*methodName=*/"isDerivedAttribute",
+      /*args=*/(ins "StringRef":$name)
+    >,
+  ];
+}
+
+#endif // MLIR_DERIVEDATTRIBUTEOPINTERFACE

mlir/lib/Interfaces/CMakeLists.txt

 set(LLVM_OPTIONAL_SOURCES
   CallInterfaces.cpp
   ControlFlowInterfaces.cpp
+  DerivedAttributeOpInterface.cpp
   InferTypeOpInterface.cpp
   SideEffects.cpp
   )
 
 add_llvm_library(MLIRCallInterfaces
   CallInterfaces.cpp
 
   ADDITIONAL_HEADER_DIRS

 add_dependencies(MLIRControlFlowInterfaces
   MLIRControlFlowInterfacesIncGen
   )
 target_link_libraries(MLIRControlFlowInterfaces
   PUBLIC
   MLIRIR
   )
 
+add_llvm_library(MLIRDerivedAttributeOpInterface
+  DerivedAttributeOpInterface.cpp
+
+  ADDITIONAL_HEADER_DIRS
+  ${MLIR_MAIN_INCLUDE_DIR}/mlir/Interfaces
+  )
+add_dependencies(MLIRDerivedAttributeOpInterface
+  MLIRDerivedAttributeOpInterfaceIncGen
+  )
+target_link_libraries(MLIRDerivedAttributeOpInterface
+  PUBLIC
+  MLIRIR
+  )
+
 add_llvm_library(MLIRInferTypeOpInterface
   InferTypeOpInterface.cpp
 
   ADDITIONAL_HEADER_DIRS
   ${MLIR_MAIN_INCLUDE_DIR}/mlir/Interfaces
   )
 add_dependencies(MLIRInferTypeOpInterface
   MLIRInferTypeOpInterfaceIncGen

mlir/lib/Interfaces/DerivedAttributeOpInterface.cpp

+//===- DerivedAttributeOpInterface.cpp -- Derived Attribute interfaces ----===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+//
+// This file contains a set of interfaces for derived attribute op interface.
+//
+//===----------------------------------------------------------------------===//
+
+#include "mlir/Interfaces/DerivedAttributeOpInterface.h"
+
+using namespace mlir;
+
+namespace mlir {
+#include "mlir/Interfaces/DerivedAttributeOpInterface.cpp.inc"
+} // namespace mlir