Page MenuHomePhabricator

[Msan] Fix the unit tests' PathToLoadable() to work on FreeBSD
ClosedPublic

Authored by kutuzov.viktor.84 on Feb 12 2015, 5:51 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

kutuzov.viktor.84 retitled this revision from to [Msan] Fix the unit tests' PathToLoadable() to work on FreeBSD.
kutuzov.viktor.84 updated this object.
kutuzov.viktor.84 edited the test plan for this revision. (Show Details)
kutuzov.viktor.84 added a subscriber: Unknown Object (MLST).
lib/msan/tests/msan_test.cc
2850 ↗(On Diff #19822)

Hm, with the returning type eliminated we may want to rename it to GetPathToLoadable()?

samsonov added inline comments.Feb 12 2015, 10:05 AM
lib/msan/tests/msan_test.cc
109 ↗(On Diff #19822)

kMaxPathLength?

2850 ↗(On Diff #19822)

Yes, please.

2862 ↗(On Diff #19822)

Please run clang-format on this diff

samsonov accepted this revision.Feb 16 2015, 2:06 PM
samsonov edited edge metadata.

LGTM

This revision is now accepted and ready to land.Feb 16 2015, 2:06 PM
This revision was automatically updated to reflect the committed changes.