Page MenuHomePhabricator

[CUDA] Add CUDA 10.2 detection
AbandonedPublic

Authored by tambre on Mar 7 2020, 5:53 AM.

Details

Reviewers
tra
jlebar

Diff Detail

Event Timeline

tambre created this revision.Mar 7 2020, 5:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 7 2020, 5:54 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
tra requested changes to this revision.Mar 9 2020, 9:45 AM

This looks like an elaborate way to achieve the effect of -Wno-unknown_cuda_version. :-)

Similar change has been discussed recently. See https://reviews.llvm.org/D74571#1875340 which details why I think it's not a good idea.

This revision now requires changes to proceed.Mar 9 2020, 9:45 AM
tambre added a comment.EditedMar 9 2020, 12:14 PM

Thanks for the context!

To avoid other people stepping into this trap, maybe it'd make sense to reword this warning to say "unsupported" instead of "unknown"?
Or maybe add detection for newer versions, but introduce a separate warning for unsupported versions?

tambre abandoned this revision.Mar 11 2020, 11:20 AM