Page MenuHomePhabricator

Correctly detect iOS simulator processes.
ClosedPublic

Authored by aprantl on Mar 5 2020, 9:55 AM.

Details

Summary

This patch detects when an ios process runs on a macOS host and
updates the target triple with the "simulator" environment.

This is part of https://bugs.swift.org/browse/SR-11971

rdar://problem/58438125

Diff Detail

Event Timeline

aprantl created this revision.Mar 5 2020, 9:55 AM
aprantl updated this revision to Diff 248634.Mar 5 2020, 5:25 PM

Here is a more principled variant of the patch. I pushed the logic down to debugserver, so we don't need to guess or fixup anything in LLDB.

friss added inline comments.Mar 5 2020, 5:38 PM
lldb/tools/debugserver/source/MacOSX/MachProcess.mm
601–607

Why not use the TARGET_OS_OSX and make the selection below be compile time rather than run time?

jasonmolenda accepted this revision.Mar 5 2020, 6:27 PM

Overall looks fine, Fred's comment is correct, nb you want to test it with #if TARGET_OS_OSX == 1, it's always defined either to 0 or 1.

lldb/test/API/functionalities/gdb_remote_client/TestWasm.py
35

TestWasm.pys response to qProcessInfo is different than the default response you added to gdbclientutils.py; it should override the qProcessInfo method to call its own version.

This revision is now accepted and ready to land.Mar 5 2020, 6:27 PM
aprantl marked an inline comment as done.Mar 6 2020, 9:43 AM
aprantl added inline comments.
lldb/test/API/functionalities/gdb_remote_client/TestWasm.py
35

Yes, but I added this line to MockGDBServerResponder.respond().

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 6 2020, 9:56 AM