This is an archive of the discontinued LLVM Phabricator instance.

Differential D75693

[GWP-ASan] Fix thread ID.
ClosedPublic

Authored by hctim on Mar 5 2020, 9:35 AM.

Details

Reviewers
morehouse
Commits
rG85c0b34fc5a5: [GWP-ASan] Fix thread ID.
Summary

GWP-ASan currently reports <unknown> thread ID, as the crash handler
merge dropped the include. Oops.

Diff Detail

Event Timeline

hctim created this revision.Mar 5 2020, 9:35 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMar 5 2020, 9:35 AM
Herald added subscribers: llvm-commits, Restricted Project. · View Herald Transcript
hctim edited reviewers, added: morehouse; removed: eugenis.Mar 5 2020, 9:35 AM
hctim edited subscribers, added: eugenis; removed: morehouse.
morehouse accepted this revision.Mar 5 2020, 9:53 AM

LGTM

This revision is now accepted and ready to land.Mar 5 2020, 9:53 AM
Harbormaster failed remote builds in B48220: Diff 248517!Mar 5 2020, 10:23 AM
Closed by commit rG85c0b34fc5a5: [GWP-ASan] Fix thread ID. (authored by hctim). · Explain WhyMar 5 2020, 10:58 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
compiler-rt/
lib/
gwp_asan/
platform_specific/
3 lines
1 line

Diff 248552

compiler-rt/lib/gwp_asan/platform_specific/common_posix.cpp

//===-- common_posix.cpp ---------------------------------*- C++ -*-===// //===-- common_posix.cpp ---------------------------------*- C++ -*-===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#include "gwp_asan/common.h" #include "gwp_asan/common.h"
#include <sys/syscall.h>
#include <unistd.h>
namespace gwp_asan { namespace gwp_asan {
uint64_t getThreadID() { uint64_t getThreadID() {
#ifdef SYS_gettid #ifdef SYS_gettid
return syscall(SYS_gettid); return syscall(SYS_gettid);
#else #else
return kInvalidThreadID; return kInvalidThreadID;
#endif #endif
} }
} // namespace gwp_asan } // namespace gwp_asan

compiler-rt/lib/gwp_asan/platform_specific/guarded_pool_allocator_posix.cpp

Show All 9 Lines
#include "gwp_asan/utilities.h" #include "gwp_asan/utilities.h"
#include <assert.h> #include <assert.h>
#include <errno.h> #include <errno.h>
#include <signal.h> #include <signal.h>
#include <stdlib.h> #include <stdlib.h>
#include <string.h> #include <string.h>
#include <sys/mman.h> #include <sys/mman.h>
#include <sys/syscall.h>
#include <sys/types.h> #include <sys/types.h>
#include <unistd.h> #include <unistd.h>
#ifdef ANDROID #ifdef ANDROID
#include <sys/prctl.h> #include <sys/prctl.h>
#define PR_SET_VMA 0x53564d41 #define PR_SET_VMA 0x53564d41
#define PR_SET_VMA_ANON_NAME 0 #define PR_SET_VMA_ANON_NAME 0
#endif // ANDROID #endif // ANDROID
▲ Show 20 Lines • Show All 60 Lines • Show Last 20 Lines