Page MenuHomePhabricator

Fix/Clarify parts of MLIR toy tutorial chapter 6+7
ClosedPublic

Authored by matthiaskramm on Feb 27 2020, 8:23 AM.

Details

Summary
  • add missing comma.
  • remove "having to register them here" phrasing, since register it is what we're doing, which made the comment a bit confusing.
  • remove duplicate code.
  • clarify link to chapter 3, since "folder" doesn't appear in that chapter.

Diff Detail

Event Timeline

matthiaskramm created this revision.Feb 27 2020, 8:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 27 2020, 8:23 AM
rriddle accepted this revision.Feb 27 2020, 10:02 AM
rriddle added inline comments.
mlir/docs/Tutorials/Toy/Ch-7.md
404

nit: Using %0 from above.

This revision is now accepted and ready to land.Feb 27 2020, 10:02 AM

Thanks for the review, River! Fixed the nit.

This revision was automatically updated to reflect the committed changes.