Page MenuHomePhabricator

[libcxx] Fix building for windows after 54fa9ecd3088508
ClosedPublic

Authored by mstorsjo on Feb 24 2020, 11:43 PM.

Details

Summary

Move the implementation of libcpp_thread_poll_with_backoff and libcpp_timed_backoff_policy::operator() out of the _LIBCPP_HAS_THREAD_API_PTHREAD block. None of the code in these methods is pthreads specific.

Also add "inline _LIBCPP_INLINE_VISIBILITY" to libcpp_timed_backoff_policy::operator(), to avoid errors due to
multiple definitions of the operator. Contrary to
libcpp_thread_poll_with_backoff (which is a template function), this is a normal non-templated method.

Diff Detail

Event Timeline

mstorsjo created this revision.Feb 24 2020, 11:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 24 2020, 11:43 PM
Herald added a subscriber: dexonsmith. · View Herald Transcript
ldionne accepted this revision.Feb 25 2020, 9:35 AM

Thanks!

This revision is now accepted and ready to land.Feb 25 2020, 9:35 AM
This revision was automatically updated to reflect the committed changes.