[ORC] Add SymbolState::Emitted to isInMaterializationPhase()

[sgraenitz]

Summary

So far isInMaterializationPhase() covered Materializing, Resolved and Ready. Shouldn't it include Emitted too?

[lhames]

I had a look over the users in Core.cpp and isInMaterializationPhase was actually being used inconsistently. I think it may have made sense when it was introduced, but shifted from its original intent at some point.

I have removed it in b7aa1cc3a43 and replaced it with direct checks on the symbol state, so I think you can discard this.

[sgraenitz]

In D75083#1892549, @lhames wrote:

I have removed it in b7aa1cc3a43 and replaced it with direct checks on the symbol state, so I think you can discard this.

That's a good solution, thanks!

llvm/include/llvm/ExecutionEngine/Orc/Core.h

public:
 
     JITTargetAddress getAddress() const { return Addr; }
     JITSymbolFlags getFlags() const { return Flags; }
     SymbolState getState() const { return static_cast<SymbolState>(State); }
 
     bool isInMaterializationPhase() const {
       return getState() == SymbolState::Materializing ||
              getState() == SymbolState::Resolved ||
+             getState() == SymbolState::Emitted ||
              getState() == SymbolState::Ready;
     }
 
     bool hasMaterializerAttached() const { return MaterializerAttached; }
     bool isPendingRemoval() const { return PendingRemoval; }
 
     void setAddress(JITTargetAddress Addr) { this->Addr = Addr; }
     void setFlags(JITSymbolFlags Flags) { this->Flags = Flags; }