Page MenuHomePhabricator

[ORC] Add SymbolState::Emitted to isInMaterializationPhase()
AbandonedPublic

Authored by sgraenitz on Feb 24 2020, 2:41 PM.

Details

Reviewers
lhames
Summary

So far isInMaterializationPhase() covered Materializing, Resolved and Ready. Shouldn't it include Emitted too?

Event Timeline

sgraenitz created this revision.Feb 24 2020, 2:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 24 2020, 2:41 PM

I had a look over the users in Core.cpp and isInMaterializationPhase was actually being used inconsistently. I think it may have made sense when it was introduced, but shifted from its original intent at some point.

I have removed it in b7aa1cc3a43 and replaced it with direct checks on the symbol state, so I think you can discard this.

sgraenitz abandoned this revision.Feb 27 2020, 12:50 PM

I have removed it in b7aa1cc3a43 and replaced it with direct checks on the symbol state, so I think you can discard this.

That's a good solution, thanks!