This is an archive of the discontinued LLVM Phabricator instance.

[ARM] Add armv6s[-]m as an alias to armv6[-]m
ClosedPublic

Authored by bsmith on Feb 9 2015, 8:24 AM.

Details

Reviewers
jroelofs
Summary

Patch to add armv6s[-]m as an alias to armv6[-]m.

LLVM currently does not model the M-class OS extension, but instead enables its features by default for armv6-m targets. Technically the correct name for this architecture would be armv6s-m, although in order to avoid breaking current use cases this patch adds armv6s-m as an alias to armv6-m instead of properly modelling the OS extension (which is probably not necessary).

(Testcases for this will be under a separate clang review).

Diff Detail

Repository
rL LLVM

Event Timeline

bsmith updated this revision to Diff 19582.Feb 9 2015, 8:24 AM
bsmith retitled this revision from to [ARM] Add armv6s[-]m as an alias to armv6[-]m.
bsmith updated this object.
bsmith edited the test plan for this revision. (Show Details)
bsmith set the repository for this revision to rL LLVM.
bsmith added a subscriber: Unknown Object (MLST).

Please add a tests in:

llvm/test/CodeGen/ARM/build-attributes.ll
llvm/test/MC/ARM/arm-thumb-cpus.s

Specifically, you should also add a note on the test for .eabi_attribute 6, 12 saying that we're emitting the wrong one when -march=armv6-m is specified on the command line, and the correct one when -march=armv6s-m is specified.

bsmith updated this revision to Diff 19658.Feb 10 2015, 3:19 AM

Add extra tests for armv6s[-]m target.

jroelofs accepted this revision.Feb 10 2015, 6:08 AM
jroelofs added a reviewer: jroelofs.

Thanks! LGTM.

This revision is now accepted and ready to land.Feb 10 2015, 6:08 AM
bsmith closed this revision.Feb 10 2015, 7:17 AM

Thanks, committed as r228696.