This is an archive of the discontinued LLVM Phabricator instance.

Differential D74895

[lldb]: fix typo in lldb-gdb-remote.txt
ClosedPublic

Authored by kwk on Feb 20 2020, 5:24 AM.

Details

Reviewers
labath
teemperor
Commits
rGc7b7f76ae6ae: [lldb]: fix typo in lldb-gdb-remote.txt
Summary

The logic of the sentence made more sense when "with" is replaced with "without".

Diff Detail

Event Timeline

kwk created this revision.Feb 20 2020, 5:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 20 2020, 5:24 AM
Herald added a subscriber: lldb-commits. · View Herald Transcript
Harbormaster completed remote builds in B46911: Diff 245623.Feb 20 2020, 5:28 AM
teemperor accepted this revision.Feb 20 2020, 5:29 AM
This revision is now accepted and ready to land.Feb 20 2020, 5:29 AM
labath accepted this revision.Feb 20 2020, 5:29 AM

yep

Closed by commit rGc7b7f76ae6ae: [lldb]: fix typo in lldb-gdb-remote.txt (authored by kwk). · Explain WhyFeb 20 2020, 5:37 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lldb/
docs/
2 lines

Diff 245623

lldb/docs/lldb-gdb-remote.txt

LLDB has added new GDB server packets to better support multi-threaded and LLDB has added new GDB server packets to better support multi-threaded and
remote debugging. Why? Normally you need to start the correct GDB and the remote debugging. Why? Normally you need to start the correct GDB and the
correct GDB server when debugging. If you have mismatch, then things go wrong correct GDB server when debugging. If you have mismatch, then things go wrong
very quickly. LLDB makes extensive use of the GDB remote protocol and we very quickly. LLDB makes extensive use of the GDB remote protocol and we
wanted to make sure that the experience was a bit more dynamic where we can wanted to make sure that the experience was a bit more dynamic where we can
discover information about a remote target with having to know anything up discover information about a remote target without having to know anything up
front. We also ran into performance issues with the existing GDB remote front. We also ran into performance issues with the existing GDB remote
protocol that can be overcome when using a reliable communications layer. protocol that can be overcome when using a reliable communications layer.
Some packets improve performance, others allow for remote process launching Some packets improve performance, others allow for remote process launching
(if you have an OS), and others allow us to dynamically figure out what (if you have an OS), and others allow us to dynamically figure out what
registers a thread might have. Again with GDB, both sides pre-agree on how the registers a thread might have. Again with GDB, both sides pre-agree on how the
registers will look (how many, their register number,name and offsets). We registers will look (how many, their register number,name and offsets). We
prefer to be able to dynamically determine what kind of architecture, OS and prefer to be able to dynamically determine what kind of architecture, OS and
vendor we are debugging, as well as how things are laid out when it comes to vendor we are debugging, as well as how things are laid out when it comes to
▲ Show 20 Lines • Show All 1,911 Lines • Show Last 20 Lines