This is an archive of the discontinued LLVM Phabricator instance.

Differential D74891

[lldb] Never compile the debugserver with Clang module flags
ClosedPublic

Authored by teemperor on Feb 20 2020, 4:07 AM.

Details

Reviewers
JDevlieghere
Commits
rG4e7c686e46c3: [lldb] Never compile the debugserver with Clang module flags
Summary

Compiling ObjC++ with Clang modules is usually not working well and compiling
the small debugserver with modules is not worth the trouble.

Diff Detail

Revision Contents

PathSize
lldb/
tools/
debugserver/
source/
8 lines

Diff 245614

lldb/tools/debugserver/source/CMakeLists.txt

Show First 20 Lines • Show All 56 Lines • ▼ Show 20 Lines
endfunction() endfunction()
# debugserver does not depend on intrinsics_gen, or on llvm. Set the common # debugserver does not depend on intrinsics_gen, or on llvm. Set the common
# llvm dependencies in the current scope to the empty set. # llvm dependencies in the current scope to the empty set.
set(LLVM_COMMON_DEPENDS) set(LLVM_COMMON_DEPENDS)
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -stdlib=libc++ -Wl,-sectcreate,__TEXT,__info_plist,${CMAKE_CURRENT_SOURCE_DIR}/../resources/lldb-debugserver-Info.plist") set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -stdlib=libc++ -Wl,-sectcreate,__TEXT,__info_plist,${CMAKE_CURRENT_SOURCE_DIR}/../resources/lldb-debugserver-Info.plist")
# Remove any module flags as the debugserver contains ObjC++ code which probably won't work
# with Clang modules.
string(REGEX REPLACE "-fmodules-cache-path=[^ ]+" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
string(REGEX REPLACE "-fmodules-local-submodule-visibility" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
string(REGEX REPLACE "-fmodules" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
string(REGEX REPLACE "-gmodules" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
string(REGEX REPLACE "-fcxx-modules" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
check_cxx_compiler_flag("-Wno-gnu-zero-variadic-macro-arguments" check_cxx_compiler_flag("-Wno-gnu-zero-variadic-macro-arguments"
CXX_SUPPORTS_NO_GNU_ZERO_VARIADIC_MACRO_ARGUMENTS) CXX_SUPPORTS_NO_GNU_ZERO_VARIADIC_MACRO_ARGUMENTS)
if (CXX_SUPPORTS_NO_GNU_ZERO_VARIADIC_MACRO_ARGUMENTS) if (CXX_SUPPORTS_NO_GNU_ZERO_VARIADIC_MACRO_ARGUMENTS)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-gnu-zero-variadic-macro-arguments") set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-gnu-zero-variadic-macro-arguments")
endif () endif ()
check_cxx_compiler_flag("-Wno-zero-length-array" check_cxx_compiler_flag("-Wno-zero-length-array"
CXX_SUPPORTS_NO_ZERO_LENGTH_ARRAY) CXX_SUPPORTS_NO_ZERO_LENGTH_ARRAY)
▲ Show 20 Lines • Show All 218 Lines • Show Last 20 Lines