Page MenuHomePhabricator

[AMDGPU] Fix DS_WRITE_B32 patterns
ClosedPublic

Authored by rampitec on Feb 19 2020, 1:29 PM.

Details

Summary

It uses VGPR_32.RegTypes which includes 16 bit types. As a
result DS_WRITE_B32 may be generated for "store i16" which
is a bug. The only reason we do not hit it now is relative
patterns complexity and sorting. Should DS_WRITE_B16 pattern
complexity become higher and the bug appears.

Diff Detail

Event Timeline

rampitec created this revision.Feb 19 2020, 1:29 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 19 2020, 1:29 PM
arsenm accepted this revision.Feb 19 2020, 1:32 PM
This revision is now accepted and ready to land.Feb 19 2020, 1:32 PM
This revision was automatically updated to reflect the committed changes.