Page MenuHomePhabricator

[compiler-rt] [builtins] Fix logb / logbl tests
ClosedPublic

Authored by luismarques on Feb 19 2020, 5:15 AM.

Details

Summary

Like was done before in D67999 for logbf, this patch fixes the tests for the internal compiler-rt implementations of logb and logbl to consider all NaNs equivalent. Not doing so was resulting in test failures for riscv64, since the the NaNs had different signs, but the spec doesn't specify the NaN signedness or payload.

The patch also fixes the test failure error message for logbl: the incorrect function name, and the %a format not being applicable to format the long double.

This addresses bug 44244 (https://bugs.llvm.org/show_bug.cgi?id=44244).

Diff Detail

Event Timeline

luismarques created this revision.Feb 19 2020, 5:15 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFeb 19 2020, 5:15 AM
Herald added subscribers: llvm-commits, Restricted Project, s.egerton and 4 others. · View Herald Transcript
luismarques edited the summary of this revision. (Show Details)Feb 19 2020, 5:31 AM
This revision is now accepted and ready to land.Feb 19 2020, 8:56 AM
rupprecht accepted this revision.Feb 19 2020, 9:04 AM

Thanks!

This revision was automatically updated to reflect the committed changes.