This is an archive of the discontinued LLVM Phabricator instance.

Differential D74670

Simplify user_id_t -> size_t
ClosedPublic

Authored by jankratochvil on Feb 15 2020, 9:56 AM.

Details

Reviewers
labath
clayborg
jdoerfert
Commits
rG516ba158b689: [lldb] [nfc] Simplify user_id_t -> size_t
Summary

As discussed in D73206 simplifying usage of user_id_t.
There is even written:

// The compile unit ID is the index of the DWARF unit.
DWARFUnit *dwarf_cu = info->GetUnitAtIndex(comp_unit->GetID());

Diff Detail

Event Timeline

jankratochvil created this revision.Feb 15 2020, 9:56 AM
Herald added a reviewer: jdoerfert. · View Herald TranscriptFeb 15 2020, 9:56 AM
Herald added a subscriber: aprantl. · View Herald Transcript
jdoerfert resigned from this revision.Feb 15 2020, 7:58 PM
labath accepted this revision.Feb 17 2020, 12:54 AM
This revision is now accepted and ready to land.Feb 17 2020, 12:54 AM
Closed by commit rG516ba158b689: [lldb] [nfc] Simplify user_id_t -> size_t (authored by jankratochvil). · Explain WhyFeb 17 2020, 1:25 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lldb/
source/
Plugins/
SymbolFile/
DWARF/
2 lines
2 lines

Diff 244925

lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h

Show All 29 Lines typedef dw_offset_t (*Callback)(SymbolFileDWARF *dwarf2Data,
DWARFDebugInfoEntry *die, DWARFDebugInfoEntry *die,
const dw_offset_t next_offset, const dw_offset_t next_offset,
const uint32_t depth, void *userData); const uint32_t depth, void *userData);
explicit DWARFDebugInfo(SymbolFileDWARF &dwarf, explicit DWARFDebugInfo(SymbolFileDWARF &dwarf,
lldb_private::DWARFContext &context); lldb_private::DWARFContext &context);
size_t GetNumUnits(); size_t GetNumUnits();
DWARFUnit *GetUnitAtIndex(lldb::user_id_t idx); DWARFUnit *GetUnitAtIndex(size_t idx);
DWARFUnit *GetUnitAtOffset(DIERef::Section section, dw_offset_t cu_offset, DWARFUnit *GetUnitAtOffset(DIERef::Section section, dw_offset_t cu_offset,
uint32_t *idx_ptr = nullptr); uint32_t *idx_ptr = nullptr);
DWARFUnit *GetUnitContainingDIEOffset(DIERef::Section section, DWARFUnit *GetUnitContainingDIEOffset(DIERef::Section section,
dw_offset_t die_offset); dw_offset_t die_offset);
DWARFUnit *GetUnit(const DIERef &die_ref); DWARFUnit *GetUnit(const DIERef &die_ref);
DWARFTypeUnit *GetTypeUnitForHash(uint64_t hash); DWARFTypeUnit *GetTypeUnitForHash(uint64_t hash);
bool ContainsTypeUnits(); bool ContainsTypeUnits();
DWARFDIE GetDIEForDIEOffset(DIERef::Section section, DWARFDIE GetDIEForDIEOffset(DIERef::Section section,
Show All 36 Lines

lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp

Show First 20 Lines • Show All 103 Lines • ▼ Show 20 Linesvoid DWARFDebugInfo::ParseUnitHeadersIfNeeded() {
llvm::sort(m_type_hash_to_unit_index, llvm::less_first()); llvm::sort(m_type_hash_to_unit_index, llvm::less_first());
} }
size_t DWARFDebugInfo::GetNumUnits() { size_t DWARFDebugInfo::GetNumUnits() {
ParseUnitHeadersIfNeeded(); ParseUnitHeadersIfNeeded();
return m_units.size(); return m_units.size();
} }
DWARFUnit *DWARFDebugInfo::GetUnitAtIndex(user_id_t idx) { DWARFUnit *DWARFDebugInfo::GetUnitAtIndex(size_t idx) {
DWARFUnit *cu = nullptr; DWARFUnit *cu = nullptr;
if (idx < GetNumUnits()) if (idx < GetNumUnits())
cu = m_units[idx].get(); cu = m_units[idx].get();
return cu; return cu;
} }
uint32_t DWARFDebugInfo::FindUnitIndex(DIERef::Section section, uint32_t DWARFDebugInfo::FindUnitIndex(DIERef::Section section,
dw_offset_t offset) { dw_offset_t offset) {
▲ Show 20 Lines • Show All 77 Lines • Show Last 20 Lines